-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code examples to Page Component Objects (EN) #1387
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
Seems the other page_object_models.*.md
are completely out of sync regarding the translation, could you please replace the content completely on that page?
Thanks!
Dear @diemol , Thank you for your review. 😄 I can add the code part, but unfortunately cannot translate the English text I added in between the paragraphs of the section. Google translate may have undesired results as I don't speak ja/pt-br/zh-cn and they also have native characters. 😅 Would you be happy for me to just put the code examples at the bottom of each non-English page? |
You do not need to translate, I meant to replace the whole content page with the English version as somehow they are not reflecting the same content. |
Hi @diemol , sorry a bit lost. 😅 Are you saying the English translation is not reflecting the changes? So far, I can only view the changes in netlify - https://deploy-preview-1387--selenium-dev.netlify.app/documentation/test_practices/encouraged/page_object_models/ |
No, no. The idea is to have the same content from the page in English on the other pages. Which means, copy the content you have in English, and replace the whole content in the other languages. Because, over time, it seems we forgot to update the other languages and the English content evolved on its own. |
Hi @diemol , from what I'm reading, it looks like we want to change all the other pages to English. If not, would you be able to provide an example for say |
Yes, all pages to English. Thanks. |
Hi @diemol , I've copied the English content to the other pages as requested. Kept the titles native. Let me know if that suffices. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* Add code examples to Page Component Objects (EN) * Update closing text * All relevant pages for page_object_models.*.md to English --------- Co-authored-by: Diego Molina <[email protected]> [deploy site] b9d1956
This PR adds much needed code examples to the Page Component Object section for the English translation.
Description
Relevant code is written in Java to complement the Page Object section, which also includes HTML structure, page object, page component object, and test methods to illustrate usage.
There are additional text written apart from the code. As the contributor is not a native of the other translations, the contribution is first made to the most used translation of the documentation.
Motivation and Context
Types of changes
Checklist