-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Start the work for the options page #1668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start the work for the options page #1668
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Description updated to latest commit (db98792)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
@diemol my Portuguese is not great but I noticed that the Portuguese translation was the only one that was lacking the browserName examples Also, I wanted to update all the ruby examples but I did not wanted to give you or others reviewers too much work in one single PR |
Yes, this was probably overlooked. Feel free to change that, please. Thanks! |
That's already changed 😊 thank you for the quick response! |
I don't see the changes. And there is an open conversation that needs to be resolved. Thank you! |
Just a comment, were you suggesting translating code examples to PT or the surrounding text? (I got confused) |
Hi Luis, I noticed that the code examples for browser name were missing in the Portuguese translations as it is now Compared to the English version: So I was wondering if it was on purpose or if the examples were missing :) Docs URL: https://www.selenium.dev/documentation/webdriver/drivers/options/ |
Perfect I will address it tonight, thank you! |
…s' into add_browser_options_ruby_examples
@diemol Regarding your request for changes, you are absolutely right, the test will not execute So I implemented an alternative solution, I added the option to skip the test automatically in rspec during execution with an explanation why, in that way we can move the code, and reference it in multiple places without executing the actual test Let me know if you like this solution, if not I will move the code back where it was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works, thank you!
* Start the work for the options page * Move upgrade to selenium examples * Update platform name * Update platform name and platform version * Add skip method --------- Co-authored-by: aguspe <[email protected]> [deploy site] 9a54ed5
User description
Description
This PR aims to start improving the example for browser options in the Selenium documentation for the ruby bindings
Currently, most of the examples are lacking and some of the code needs to be moved
Examples:
Motivation and Context
For both newcomers and experienced Selenium users is important to have up-to-date documentation that they can rely on
This update will be split into multiple PRs to not make one big PR and to start updating the documentation right now
Types of changes
Checklist
Type
enhancement, documentation
Description
Changes walkthrough
options_spec.rb
Enhance Ruby Examples for Browser Options
examples/ruby/spec/drivers/options_spec.rb
strategies and remote capabilities.
platform name, browser version, and cloud options.
options.en.md
Update Ruby Examples in WebDriver Options Documentation
website_and_docs/content/documentation/webdriver/drivers/options.en.md
options_spec.rb
.options.ja.md
Update Japanese WebDriver Options Documentation with Ruby Examples
website_and_docs/content/documentation/webdriver/drivers/options.ja.md
options_spec.rb
.options.pt-br.md
Enhance Portuguese WebDriver Options Documentation with Ruby Examples
website_and_docs/content/documentation/webdriver/drivers/options.pt-br.md
Portuguese readers.
options.zh-cn.md
Update Chinese WebDriver Options Documentation with Ruby Examples
website_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md
documentation.
upgrade_to_selenium_4.en.md
Update Upgrade to Selenium 4 Documentation with New Ruby Examples
website_and_docs/content/documentation/webdriver/troubleshooting/upgrade_to_selenium_4.en.md
options_spec.rb
examples for upgrading to Selenium 4.