-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Upgrade selenium 4 ruby examples & rendering issue #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade selenium 4 ruby examples & rendering issue #1695
Conversation
…o expand_options_example_page
…o expand_options_example_page
…o expand_options_example_page
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Description updated to latest commit (5ae210d)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
HI @aguspe, Thank you for the PR. could you please look into conflicts. Thanks, |
Hi @harsha509 Thank you for the help, Let me know if everything else is needed and have a great weeekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aguspe !
@harsha509 Thank you :) I will continue updating the ruby documentation today, have a nice day! |
…deploy site] * Expand options documentation test and examples * Update timeouts examples * Update all navigations * Update options after updating the tests * Update options after updating the tests * Fix documentation bug * Fix documentation issue and migrate ruby code * Fix proxy documentation issue --------- Co-authored-by: aguspe <[email protected]> Co-authored-by: Sri Harsha <[email protected]>
Description
This PR updates the upgrade to selenium 4 documentation to avoid the wrong rendering of the ruby examples and also moves the ruby examples for the before section to the options_spec file
This PR needs to be merged after #1679
Motivation and Context
Currently due to changes I introduced in #1668 the rendering of the ruby example in the upgrade selenium page is wrong:
This PR fixes that and migrates the ruby example on the before tab
Types of changes
Checklist