-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Expand options documentation test and examples for Ruby #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand options documentation test and examples for Ruby #1679
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Description updated to latest commit (49af31b)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
Hello @diemol one question about the documentation, does it make sense that the timeouts are under the options page and not on its page? If it does, I can also update the timeouts example on this PR ![]() |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
Hi @aguspe, The timeout mentioned refers to the W3C capability timeout in W3C WebDriver, see https://www.w3.org/TR/webdriver2/#capabilities Also, It covers features like So, I believe it's correctly included in the driver options section. Thanks, |
Thank you so much for the help I have updated this PR to cover the timeout examples :) |
…o expand_options_example_page
Hi @harsha509 before this gets merged I need to update some lines because I added a new let on the Rspec test so I'm missing some updates |
HI @aguspe , can you do it in a new PR if possible ? let me know Thanks, |
I just updated it in a commit here and I fixed a documentation bug, I hope that's okey |
Hello @harsha509 would it be possible to merge this PR? I will create a new PR to expand the selenium docs and correct an issue with the upgrade selenium ruby example but I keep merging trunk into this PR because it gets out of sync :) Thank you so much |
This PR needs to be merged before #1695 |
Thank you @aguspe ! |
)[deploy site] * Expand options documentation test and examples * Update timeouts examples * Update all navigations * Update options after updating the tests * Update options after updating the tests * Fix documentation bug --------- Co-authored-by: aguspe <[email protected]>
User description
Description
This PR adds extra tests for the options in ruby and updates the documentation examples, besides that, it also moves the proxy example from the documentation file
Motivation and Context
For new and experienced user to be able to fully understand all the options offered by Selenium is important to have up-to-date documentation with examples
Types of changes
Checklist
Type
Enhancement, Tests, Documentation
Description
Changes walkthrough
options_spec.rb
Expand Selenium WebDriver Options Tests in Ruby
examples/ruby/spec/drivers/options_spec.rb
window rect, strict file interactability, and proxy settings in Chrome
and Firefox.
options.en.md
Update English WebDriver Options Documentation with Ruby Examples
website_and_docs/content/documentation/webdriver/drivers/options.en.md
options_spec.rb.
options.ja.md
Update Japanese WebDriver Options Documentation with Ruby Examples
website_and_docs/content/documentation/webdriver/drivers/options.ja.md
examples.
options.pt-br.md
Update Brazilian Portuguese WebDriver Options Documentation with Ruby
Examples
website_and_docs/content/documentation/webdriver/drivers/options.pt-br.md
Ruby test examples.
options.zh-cn.md
Update Chinese WebDriver Options Documentation with Ruby Examples
website_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md
examples.