[pull] main from modelcontextprotocol:main #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Co-authored-by: Marcelo Trylesinski <[email protected]>
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
Reviewer's Guide by SourceryThis pull request introduces several type hint improvements to the mcp module, enhancing code clarity and maintainability. It also addresses a type error issue related to lifespan context by adding a new test case. Additionally, it includes minor changes to assertion messages and updates to generic type parameters. Updated class diagram for Request and NotificationclassDiagram
class Request~RequestParamsT, MethodT~ {
<<Abstract>>
jsonrpc: Literal[\'2.0\']
id: RequestId
method: MethodT
params: RequestParamsT
}
class Notification~NotificationParamsT, MethodT~ {
<<Abstract>>
jsonrpc: Literal[\'2.0\']
method: MethodT
params: NotificationParamsT
}
Request --|> JSONRPCRequest : Inherits
Request --|> InitializeRequest : Inherits
Request --|> PingRequest : Inherits
Request --|> ListResourcesRequest : Inherits
Request --|> ListResourceTemplatesRequest : Inherits
Request --|> ReadResourceRequest : Inherits
Request --|> SubscribeRequest : Inherits
Request --|> UnsubscribeRequest : Inherits
Request --|> ListPromptsRequest : Inherits
Request --|> GetPromptRequest : Inherits
Request --|> ListToolsRequest : Inherits
Request --|> CallToolRequest : Inherits
Request --|> SetLevelRequest : Inherits
Request --|> CreateMessageRequest : Inherits
Request --|> CompleteRequest : Inherits
Request --|> ListRootsRequest : Inherits
Notification --|> JSONRPCNotification : Inherits
Notification --|> InitializedNotification : Inherits
Notification --|> ProgressNotification : Inherits
Notification --|> ResourceListChangedNotification : Inherits
Notification --|> ResourceUpdatedNotification : Inherits
Notification --|> PromptListChangedNotification : Inherits
Notification --|> ToolListChangedNotification : Inherits
Notification --|> LoggingMessageNotification : Inherits
Notification --|> RootsListChangedNotification : Inherits
note for Request "Generic types added to Request"
note for Notification "Generic types added to Notification"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Enhance type annotations and generics for Model Context Protocol (MCP) types and improve type safety across various components
New Features:
Enhancements:
Tests:
Chores: