feat: added physics directory and ground to ground projectile motion algorithm #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
approved these changes
Oct 20, 2022
mishraabhinn
approved these changes
Oct 22, 2022
|
@mishraabhinn This pull request should not have been merged. There are changes requested. |
I did not see any. |
|
@Focusucof Please recreate the pull-request with the suggested changes made. |
vil02
added a commit
to vil02/C-Plus-Plus
that referenced
this pull request
Dec 28, 2022
* chore: fix Markdown formatting in `dynamic_programming/kadane2.cpp` (TheAlgorithms#2276) * docs: fix grammatical errors and typos (TheAlgorithms#2201) * docs: fix grammatical errors and typos * compilation error fixed * Revert "compilation error fixed" This reverts commit 0083cbf. * feat: added physics directory and ground to ground projectile motion algorithm (TheAlgorithms#2279) * feat: added physics folder, ground to ground projectile motion calculations * feat: added max height function * fix: bug in angle calculations * test: added test cases * docs: added comments to test case variables * docs: added comments to calculations * fix: changed floats to doubles * updating DIRECTORY.md * Update physics/ground_to_ground_projectile_motion.cpp Co-authored-by: David Leal <[email protected]> * chore: add missing namespace * rerun checks Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> * docs: updated a logically wrong doc comment (TheAlgorithms#2329) * feat: add CMakeLists to the `divide_and_conquer` directory (TheAlgorithms#2072) * fix: stairs pattern not printing slash (TheAlgorithms#2111) when we propose 2 backslash then it doesn't take it as a comment and gets printed Co-authored-by: David Leal <[email protected]> * fix: use FreeGlut newest GitHub link (TheAlgorithms#2397) * updating DIRECTORY.md * fix: use FreeGlut newest GitHub link * chore(fix): `data_strcutres` -> `data_structures` (TheAlgorithms#2399) * feat: add Find non repeating number implementation (TheAlgorithms#2061) * add find_single_number * add fix issues * remove .vscode * add .vscode * Update .vscode/settings.json Co-authored-by: David Leal <[email protected]> * chore(fix): minor issues Co-authored-by: David Leal <[email protected]> * [feat/docs]: improve the `quick_sort.cpp` algorithm (TheAlgorithms#2396) * [feat/docs]: improve the `quick_sort.cpp`... ...algorithm implementation. * clang-format and clang-tidy fixes for 40c858b * chore(fix): add original author * updating DIRECTORY.md * chore: update Discord links (TheAlgorithms#2407) * docs: remove unneeded Markdown header * feat: improve the Awesome Workflow (TheAlgorithms#2408) * fix: Awesome Workflow issues Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176 * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * feat: various improvements * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * chore: remove LGTM and fix... ...CodeQL badges. * docs: add guide on integrating CMake (TheAlgorithms#2410) Taken from TheAlgorithms/C#1163 * updating DIRECTORY.md Co-authored-by: Daemon <[email protected]> Co-authored-by: aadarshkt <[email protected]> Co-authored-by: Focus <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> Co-authored-by: Arjit Malik <[email protected]> Co-authored-by: Harsh Singh <[email protected]> Co-authored-by: Ravi Dev Pandey <[email protected]> Co-authored-by: Mehmet <[email protected]> Co-authored-by: Taj <[email protected]> Co-authored-by: github-actions[bot] <[email protected]>
Panquesito7
added a commit
that referenced
this pull request
Jan 10, 2023
* fix: remove memory leak in stack * style: use camelCase * style: simplify logic * style: rename stack.h to stack.hpp * updating DIRECTORY.md * clang-format and clang-tidy fixes for 2205c6f * fix: remove redundant file name Co-authored-by: David Leal <[email protected]> * clang-format and clang-tidy fixes for a080aaa * refactor: use std::shared_ptr * fix: use C++11 * chore: synchronize with master (#2) * chore: fix Markdown formatting in `dynamic_programming/kadane2.cpp` (#2276) * docs: fix grammatical errors and typos (#2201) * docs: fix grammatical errors and typos * compilation error fixed * Revert "compilation error fixed" This reverts commit 0083cbf. * feat: added physics directory and ground to ground projectile motion algorithm (#2279) * feat: added physics folder, ground to ground projectile motion calculations * feat: added max height function * fix: bug in angle calculations * test: added test cases * docs: added comments to test case variables * docs: added comments to calculations * fix: changed floats to doubles * updating DIRECTORY.md * Update physics/ground_to_ground_projectile_motion.cpp Co-authored-by: David Leal <[email protected]> * chore: add missing namespace * rerun checks Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> * docs: updated a logically wrong doc comment (#2329) * feat: add CMakeLists to the `divide_and_conquer` directory (#2072) * fix: stairs pattern not printing slash (#2111) when we propose 2 backslash then it doesn't take it as a comment and gets printed Co-authored-by: David Leal <[email protected]> * fix: use FreeGlut newest GitHub link (#2397) * updating DIRECTORY.md * fix: use FreeGlut newest GitHub link * chore(fix): `data_strcutres` -> `data_structures` (#2399) * feat: add Find non repeating number implementation (#2061) * add find_single_number * add fix issues * remove .vscode * add .vscode * Update .vscode/settings.json Co-authored-by: David Leal <[email protected]> * chore(fix): minor issues Co-authored-by: David Leal <[email protected]> * [feat/docs]: improve the `quick_sort.cpp` algorithm (#2396) * [feat/docs]: improve the `quick_sort.cpp`... ...algorithm implementation. * clang-format and clang-tidy fixes for 40c858b * chore(fix): add original author * updating DIRECTORY.md * chore: update Discord links (#2407) * docs: remove unneeded Markdown header * feat: improve the Awesome Workflow (#2408) * fix: Awesome Workflow issues Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176 * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * feat: various improvements * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * chore: remove LGTM and fix... ...CodeQL badges. * docs: add guide on integrating CMake (#2410) Taken from TheAlgorithms/C#1163 * updating DIRECTORY.md Co-authored-by: Daemon <[email protected]> Co-authored-by: aadarshkt <[email protected]> Co-authored-by: Focus <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> Co-authored-by: Arjit Malik <[email protected]> Co-authored-by: Harsh Singh <[email protected]> Co-authored-by: Ravi Dev Pandey <[email protected]> Co-authored-by: Mehmet <[email protected]> Co-authored-by: Taj <[email protected]> Co-authored-by: github-actions[bot] <[email protected]> * docs: update authors and include comments apply suggestions of @Panquesito7 Co-authored-by: David Leal <[email protected]> * style: apply clang-format * clang-format and clang-tidy fixes for b35b721 * style: make display and isEmptyStack const * tests: remove test_stack_legacy.cpp * style: throw invalid_argument from top and pop if stack empty * updating DIRECTORY.md * style: add missing include docs, remove cassert * style: use assert macro, document includes * fix: use const reference in lambdas in display and toVector * style: remove shared_ptr from traverse Co-authored-by: David Leal <[email protected]> Co-authored-by: Daemon <[email protected]> Co-authored-by: aadarshkt <[email protected]> Co-authored-by: Focus <[email protected]> Co-authored-by: Arjit Malik <[email protected]> Co-authored-by: Harsh Singh <[email protected]> Co-authored-by: Ravi Dev Pandey <[email protected]> Co-authored-by: Mehmet <[email protected]> Co-authored-by: Taj <[email protected]> Co-authored-by: github-actions[bot] <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added a directory for physics related algorithms. Added a ground to ground projectile motion calculator algorithm.
Checklist
Notes:
The added file (in physics/ground_to_ground_projectile_motion.cpp) has functions to calculate the time of flight, the horizontal range, and the max height of a projectile launched from the ground.