Fix Awesome Workflow #1176

tjgurwara99 · 2022-12-09T16:57:37Z

Description of Change

Currently the awesome workflow's are failing for all of the PR. The reason for it is that the ubuntu repository has removed the package that we used to install clang-format-10 and clang-tidy-10 and it has been replaced by other packages. I propose that these packages shouldn't be linked to a static version in order to make sure that this kind of situation doesn't occur again.

PS: I had also renamed the Codeql file and made some changes, I don't think there is any difference to the one that was already commit to it except that runs-on being a array of different environments to build the codeql analysis for. If it turns out that you don't require this change, it would be easy for me to remove that from this branch, just let me know.

Checklist

Added description of change
Added file name matches File name guidelines
I acknowledge that all my contributions will be made under the project's license.

Panquesito7 · 2022-12-09T17:40:11Z

.github/workflows/codeql.yml

+jobs:
+  analyze:
+    name: Analyze
+    runs-on: [ubuntu-latest, windows-latest, macos-latest]


This won't work properly. I believe we need to use a matrix.
Having it the current way will make an infinite action which will never finish.

Suggested change

runs-on: [ubuntu-latest, windows-latest, macos-latest]

runs-on: ${{ matrix.os }}

I don't think that is the case from the looks of the documentation here. Are you sure?

There is no "write" step in this plus GitHub prevents a situation where if an action updates a repository then that doesn't launch another action, so I don't think there is any infinite cycle of actions here.

I've still changed the above since it was getting stuck in trying to find runners (check your actions setting for this repo - it might not have windows or macOS runner provisioned).

Are you sure?

I believe so. I've done it in other repositories and it doesn't work. When I use matrix.os, it works.

Oh I think you're right. I will see what I can do 😄

Panquesito7 · 2022-12-09T17:40:38Z

.github/workflows/codeql.yml

+      matrix:
+        language: [ 'cpp' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+        # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support


Suggested change

# Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support

# Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support

os: [windows-latest, ubuntu-latest, macOS-latest]

I think this won't work because the scope of os is above the definition of the matrix.os. I've just used ubuntu-latest for now. We can change it if something changes 😄

Panquesito7

Looks good. Thanks! 🚀
The other stuff can be addressed in another PR. This is something that must be fixed ASAP.

@tjgurwara99

Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176

@tjgurwara99

Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176

@tjgurwara99

* fix: Awesome Workflow issues Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176 * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * feat: various improvements * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]>

@tjgurwara99

* chore: fix Markdown formatting in `dynamic_programming/kadane2.cpp` (TheAlgorithms#2276) * docs: fix grammatical errors and typos (TheAlgorithms#2201) * docs: fix grammatical errors and typos * compilation error fixed * Revert "compilation error fixed" This reverts commit 0083cbf. * feat: added physics directory and ground to ground projectile motion algorithm (TheAlgorithms#2279) * feat: added physics folder, ground to ground projectile motion calculations * feat: added max height function * fix: bug in angle calculations * test: added test cases * docs: added comments to test case variables * docs: added comments to calculations * fix: changed floats to doubles * updating DIRECTORY.md * Update physics/ground_to_ground_projectile_motion.cpp Co-authored-by: David Leal <[email protected]> * chore: add missing namespace * rerun checks Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> * docs: updated a logically wrong doc comment (TheAlgorithms#2329) * feat: add CMakeLists to the `divide_and_conquer` directory (TheAlgorithms#2072) * fix: stairs pattern not printing slash (TheAlgorithms#2111) when we propose 2 backslash then it doesn't take it as a comment and gets printed Co-authored-by: David Leal <[email protected]> * fix: use FreeGlut newest GitHub link (TheAlgorithms#2397) * updating DIRECTORY.md * fix: use FreeGlut newest GitHub link * chore(fix): `data_strcutres` -> `data_structures` (TheAlgorithms#2399) * feat: add Find non repeating number implementation (TheAlgorithms#2061) * add find_single_number * add fix issues * remove .vscode * add .vscode * Update .vscode/settings.json Co-authored-by: David Leal <[email protected]> * chore(fix): minor issues Co-authored-by: David Leal <[email protected]> * [feat/docs]: improve the `quick_sort.cpp` algorithm (TheAlgorithms#2396) * [feat/docs]: improve the `quick_sort.cpp`... ...algorithm implementation. * clang-format and clang-tidy fixes for 40c858b * chore(fix): add original author * updating DIRECTORY.md * chore: update Discord links (TheAlgorithms#2407) * docs: remove unneeded Markdown header * feat: improve the Awesome Workflow (TheAlgorithms#2408) * fix: Awesome Workflow issues Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176 * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * feat: various improvements * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * chore: remove LGTM and fix... ...CodeQL badges. * docs: add guide on integrating CMake (TheAlgorithms#2410) Taken from TheAlgorithms/C#1163 * updating DIRECTORY.md Co-authored-by: Daemon <[email protected]> Co-authored-by: aadarshkt <[email protected]> Co-authored-by: Focus <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> Co-authored-by: Arjit Malik <[email protected]> Co-authored-by: Harsh Singh <[email protected]> Co-authored-by: Ravi Dev Pandey <[email protected]> Co-authored-by: Mehmet <[email protected]> Co-authored-by: Taj <[email protected]> Co-authored-by: github-actions[bot] <[email protected]>

@tjgurwara99

* fix: remove memory leak in stack * style: use camelCase * style: simplify logic * style: rename stack.h to stack.hpp * updating DIRECTORY.md * clang-format and clang-tidy fixes for 2205c6f * fix: remove redundant file name Co-authored-by: David Leal <[email protected]> * clang-format and clang-tidy fixes for a080aaa * refactor: use std::shared_ptr * fix: use C++11 * chore: synchronize with master (#2) * chore: fix Markdown formatting in `dynamic_programming/kadane2.cpp` (#2276) * docs: fix grammatical errors and typos (#2201) * docs: fix grammatical errors and typos * compilation error fixed * Revert "compilation error fixed" This reverts commit 0083cbf. * feat: added physics directory and ground to ground projectile motion algorithm (#2279) * feat: added physics folder, ground to ground projectile motion calculations * feat: added max height function * fix: bug in angle calculations * test: added test cases * docs: added comments to test case variables * docs: added comments to calculations * fix: changed floats to doubles * updating DIRECTORY.md * Update physics/ground_to_ground_projectile_motion.cpp Co-authored-by: David Leal <[email protected]> * chore: add missing namespace * rerun checks Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> * docs: updated a logically wrong doc comment (#2329) * feat: add CMakeLists to the `divide_and_conquer` directory (#2072) * fix: stairs pattern not printing slash (#2111) when we propose 2 backslash then it doesn't take it as a comment and gets printed Co-authored-by: David Leal <[email protected]> * fix: use FreeGlut newest GitHub link (#2397) * updating DIRECTORY.md * fix: use FreeGlut newest GitHub link * chore(fix): `data_strcutres` -> `data_structures` (#2399) * feat: add Find non repeating number implementation (#2061) * add find_single_number * add fix issues * remove .vscode * add .vscode * Update .vscode/settings.json Co-authored-by: David Leal <[email protected]> * chore(fix): minor issues Co-authored-by: David Leal <[email protected]> * [feat/docs]: improve the `quick_sort.cpp` algorithm (#2396) * [feat/docs]: improve the `quick_sort.cpp`... ...algorithm implementation. * clang-format and clang-tidy fixes for 40c858b * chore(fix): add original author * updating DIRECTORY.md * chore: update Discord links (#2407) * docs: remove unneeded Markdown header * feat: improve the Awesome Workflow (#2408) * fix: Awesome Workflow issues Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176 * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * feat: various improvements * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * chore: remove LGTM and fix... ...CodeQL badges. * docs: add guide on integrating CMake (#2410) Taken from TheAlgorithms/C#1163 * updating DIRECTORY.md Co-authored-by: Daemon <[email protected]> Co-authored-by: aadarshkt <[email protected]> Co-authored-by: Focus <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> Co-authored-by: Arjit Malik <[email protected]> Co-authored-by: Harsh Singh <[email protected]> Co-authored-by: Ravi Dev Pandey <[email protected]> Co-authored-by: Mehmet <[email protected]> Co-authored-by: Taj <[email protected]> Co-authored-by: github-actions[bot] <[email protected]> * docs: update authors and include comments apply suggestions of @Panquesito7 Co-authored-by: David Leal <[email protected]> * style: apply clang-format * clang-format and clang-tidy fixes for b35b721 * style: make display and isEmptyStack const * tests: remove test_stack_legacy.cpp * style: throw invalid_argument from top and pop if stack empty * updating DIRECTORY.md * style: add missing include docs, remove cassert * style: use assert macro, document includes * fix: use const reference in lambdas in display and toVector * style: remove shared_ptr from traverse Co-authored-by: David Leal <[email protected]> Co-authored-by: Daemon <[email protected]> Co-authored-by: aadarshkt <[email protected]> Co-authored-by: Focus <[email protected]> Co-authored-by: Arjit Malik <[email protected]> Co-authored-by: Harsh Singh <[email protected]> Co-authored-by: Ravi Dev Pandey <[email protected]> Co-authored-by: Mehmet <[email protected]> Co-authored-by: Taj <[email protected]> Co-authored-by: github-actions[bot] <[email protected]>

@tjgurwara99

* fix: Awesome Workflow issues Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176 * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * feat: various improvements * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]>

@tjgurwara99

* fix: remove memory leak in stack * style: use camelCase * style: simplify logic * style: rename stack.h to stack.hpp * updating DIRECTORY.md * clang-format and clang-tidy fixes for 2205c6f1 * fix: remove redundant file name Co-authored-by: David Leal <[email protected]> * clang-format and clang-tidy fixes for a080aaa2 * refactor: use std::shared_ptr * fix: use C++11 * chore: synchronize with master (#2) * chore: fix Markdown formatting in `dynamic_programming/kadane2.cpp` (#2276) * docs: fix grammatical errors and typos (#2201) * docs: fix grammatical errors and typos * compilation error fixed * Revert "compilation error fixed" This reverts commit 0083cbfd1a9c6bde2410d426892c84467142c689. * feat: added physics directory and ground to ground projectile motion algorithm (#2279) * feat: added physics folder, ground to ground projectile motion calculations * feat: added max height function * fix: bug in angle calculations * test: added test cases * docs: added comments to test case variables * docs: added comments to calculations * fix: changed floats to doubles * updating DIRECTORY.md * Update physics/ground_to_ground_projectile_motion.cpp Co-authored-by: David Leal <[email protected]> * chore: add missing namespace * rerun checks Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> * docs: updated a logically wrong doc comment (#2329) * feat: add CMakeLists to the `divide_and_conquer` directory (#2072) * fix: stairs pattern not printing slash (#2111) when we propose 2 backslash then it doesn't take it as a comment and gets printed Co-authored-by: David Leal <[email protected]> * fix: use FreeGlut newest GitHub link (#2397) * updating DIRECTORY.md * fix: use FreeGlut newest GitHub link * chore(fix): `data_strcutres` -> `data_structures` (#2399) * feat: add Find non repeating number implementation (#2061) * add find_single_number * add fix issues * remove .vscode * add .vscode * Update .vscode/settings.json Co-authored-by: David Leal <[email protected]> * chore(fix): minor issues Co-authored-by: David Leal <[email protected]> * [feat/docs]: improve the `quick_sort.cpp` algorithm (#2396) * [feat/docs]: improve the `quick_sort.cpp`... ...algorithm implementation. * clang-format and clang-tidy fixes for 40c858ba * chore(fix): add original author * updating DIRECTORY.md * chore: update Discord links (#2407) * docs: remove unneeded Markdown header * feat: improve the Awesome Workflow (#2408) * fix: Awesome Workflow issues Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176 * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * feat: various improvements * chore: apply suggestions from code review Co-authored-by: Taj <[email protected]> * chore: remove LGTM and fix... ...CodeQL badges. * docs: add guide on integrating CMake (#2410) Taken from TheAlgorithms/C#1163 * updating DIRECTORY.md Co-authored-by: Daemon <[email protected]> Co-authored-by: aadarshkt <[email protected]> Co-authored-by: Focus <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: David Leal <[email protected]> Co-authored-by: Arjit Malik <[email protected]> Co-authored-by: Harsh Singh <[email protected]> Co-authored-by: Ravi Dev Pandey <[email protected]> Co-authored-by: Mehmet <[email protected]> Co-authored-by: Taj <[email protected]> Co-authored-by: github-actions[bot] <[email protected]> * docs: update authors and include comments apply suggestions of @Panquesito7 Co-authored-by: David Leal <[email protected]> * style: apply clang-format * clang-format and clang-tidy fixes for b35b7214 * style: make display and isEmptyStack const * tests: remove test_stack_legacy.cpp * style: throw invalid_argument from top and pop if stack empty * updating DIRECTORY.md * style: add missing include docs, remove cassert * style: use assert macro, document includes * fix: use const reference in lambdas in display and toVector * style: remove shared_ptr from traverse Co-authored-by: David Leal <[email protected]> Co-authored-by: Daemon <[email protected]> Co-authored-by: aadarshkt <[email protected]> Co-authored-by: Focus <[email protected]> Co-authored-by: Arjit Malik <[email protected]> Co-authored-by: Harsh Singh <[email protected]> Co-authored-by: Ravi Dev Pandey <[email protected]> Co-authored-by: Mehmet <[email protected]> Co-authored-by: Taj <[email protected]> Co-authored-by: github-actions[bot] <[email protected]>

Delete codeql_analysis.yml

af2ad69

tjgurwara99 mentioned this pull request Dec 9, 2022

docs: add guide on integrating CMake #1163

Merged

7 tasks

Panquesito7 requested changes Dec 9, 2022

View reviewed changes

Panquesito7 added the bugfix Correction to existing algorithms label Dec 9, 2022

tjgurwara99 force-pushed the master branch 3 times, most recently from bae3e01 to aac6808 Compare December 13, 2022 20:03

fixing workflows

87c6334

tjgurwara99 force-pushed the master branch from aac6808 to 87c6334 Compare December 13, 2022 20:04

tjgurwara99 requested a review from Panquesito7 December 13, 2022 20:10

Panquesito7 approved these changes Dec 16, 2022

View reviewed changes

Panquesito7 merged commit c97a33a into TheAlgorithms:master Dec 16, 2022

Panquesito7 added a commit to TheAlgorithms/C-Plus-Plus that referenced this pull request Dec 16, 2022

fix: Awesome Workflow issues

290d363

Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176

Panquesito7 mentioned this pull request Dec 16, 2022

feat: improve the Awesome Workflow TheAlgorithms/C-Plus-Plus#2408

Merged

8 tasks

Panquesito7 added a commit to TheAlgorithms/C-Plus-Plus that referenced this pull request Dec 16, 2022

fix: Awesome Workflow issues

02b1e65

Thanks to @tjgurwara99 for the original fix: TheAlgorithms/C#1176

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Awesome Workflow #1176

Fix Awesome Workflow #1176

tjgurwara99 commented Dec 9, 2022 •

edited

Loading

Panquesito7 Dec 9, 2022 •

edited

Loading

tjgurwara99 Dec 13, 2022 •

edited

Loading

Panquesito7 Dec 16, 2022

tjgurwara99 Dec 16, 2022

Panquesito7 Dec 9, 2022

tjgurwara99 Dec 13, 2022

Panquesito7 left a comment

	runs-on: [ubuntu-latest, windows-latest, macos-latest]
	runs-on: ${{ matrix.os }}

	# Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
	# Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
	os: [windows-latest, ubuntu-latest, macOS-latest]

Fix Awesome Workflow #1176

Fix Awesome Workflow #1176

Conversation

tjgurwara99 commented Dec 9, 2022 • edited Loading

Description of Change

Checklist

Panquesito7 Dec 9, 2022 • edited Loading

Choose a reason for hiding this comment

tjgurwara99 Dec 13, 2022 • edited Loading

Choose a reason for hiding this comment

Panquesito7 Dec 16, 2022

Choose a reason for hiding this comment

tjgurwara99 Dec 16, 2022

Choose a reason for hiding this comment

Panquesito7 Dec 9, 2022

Choose a reason for hiding this comment

tjgurwara99 Dec 13, 2022

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

tjgurwara99 commented Dec 9, 2022 •

edited

Loading

Panquesito7 Dec 9, 2022 •

edited

Loading

tjgurwara99 Dec 13, 2022 •

edited

Loading