-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
feat: add boyer moore algorithm implementation #2441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the clang-tidy
warnings.
Let us know if you need any help with that. 🙂
Co-authored-by: David Leal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the problem! As I was fixing clang-tidy warnings I changed a type which should not be changed. Now tests are fine and I dont see any clang-tidy warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contributions! Just a little bit more ❤️
also @Panquesito7 there seems to be both @ return and @ returns in the contribution guidelines and both are used interchangeably? |
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little bit more!!! 🙂
Co-authored-by: realstealthninja <[email protected]>
Good question. I think we might want to standardize the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: David Leal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Thank you. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! ❤️
Description of Change
Checklist
Notes: This implementation is mine, but the algorithm itself is similar to one I saw on geeksforgeeks (as I learned about the algorithm from there). There are other ways to implement the good suffix table, but I truly find this one the best.