Patch action Godocmd #434
Closed
Patch action Godocmd #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raklaptudirm
approved these changes
Nov 10, 2021
siriak
approved these changes
Nov 11, 2021
|
@siriak, could we potentially create a PAT for this action? I don't think it will be able to write to master with the default token. If we can't the other solution I have is to combine golanci-lint action and godocmd action together and make sure that godocmd runs before linting so that it's doesn't start again after commit from godocmd. |
|
@tjgurwara99 We can make a special token for that action, just let me know what I should do :) |
|
Yes, please. Can you create a token so that it can write directly to master cause quite a few actions are failing 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The godocmd action triggers an update on the branch but an action doesn't trigger an event and therefore if the new changes are pushed to the branch, no new actions will run - this includes golangci-lint-and-test action that we have which is a
requiredaction for all PRs and must satisfy this so it gets stuck in this because it will never get triggered 😓. The immediate fix is that the PR would not trigger this action, instead when the merge happens the action would be triggered and it would run as expected. Although, there is a possibility that this might not work because the master branch is protected and the push to master fails. This related to #407