-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: add Conversion/base64 algorithm #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi everyone! You'll find in my pull request an implementation of base64 encoding/decoding according to RFC4648. Here are the benchmark results on my computer:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that everything else seems to be okay.
@tjgurwara99 Thanks for the review, useful feedback! I updated the pull request accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this, I don't think base64 is a cipher. Its a conversion. Can you move this to the conversion package instead.
Indeed I thought about it but saw on the The algorithms website that it was categorized as a Cipher for both C++ and Python (although it is categorized as "conversions" for js), so I used the cipher package for consistency. But I can definitely move it to the conversion package if you confirm? |
Yeah, move it to conversion package. Its more appropriate there. |
I moved the code to the conversion package and renamed the function to be more precise, since the package name is not "base64" anymore. |
@tjgurwara99 The |
A basic implementation of the base64 encoding algorithm, based on RFC4648.