adding formatting steps in pull request template #4606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asapekia
commented
Oct 3, 2023
asapekia
commented
- I have read CONTRIBUTING.md.
- This pull request is all my own work -- I have not plagiarized it.
- All filenames are in PascalCase.
- All functions and variable names follow Java naming conventions.
- All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
asapekia
requested review from
yanglbme,
debasishbsws,
vil02 and
BamaCharanChhandogi
as code owners
|
@vil02 added the steps that you had shared with me for formatting in contribution md |
|
@vil02 please review |
vil02
reviewed
Oct 7, 2023
|
I'd add it as a checkbox in the PR template. This way it is (hopefully) read by everybody opening PRs. |
|
okay will raise a PR to add it in PR template. |
No! Please do not open a new PR. there are already too many. We can change the title of this one. Everything will be fine. |
|
okay @vil02 will make the changes in this PR only. |
asapekia
changed the title
|
@vil02 removed the changes from contribution.md and added to pr template. Please review. |
siriak
reviewed
Oct 8, 2023
|
@vil02 please review |
vil02
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.