Skip to content

adding formatting steps in pull request template #4606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 8, 2023
Merged

adding formatting steps in pull request template #4606

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
69210aa
adding formatting steps in contribution.md
asapekia Oct 3, 2023
4f50518
Merge branch 'master' into format-steps
asapekia Oct 3, 2023
fc46baf
Merge branch 'master' into format-steps
asapekia Oct 5, 2023
afb2269
adding format to pull request template
asapekia Oct 7, 2023
c29c16e
made format instruction shorter
asapekia Oct 8, 2023
381f850
Merge branch 'master' into format-steps
vil02 Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ In order to reduce the number of notifications sent to the maintainers, please:
- [ ] All filenames are in PascalCase.
- [ ] All functions and variable names follow Java naming conventions.
- [ ] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
- [ ] Ensure your code is properly formatted by using the command ```clang-format -i --style=file path/to/your/file.java```
If you do not have the correct version of clang-format (i.e. < 16.0), you can remove **InsertNewlineAtEOF: true** from
**java/.clang-format** and manually add a newline at the end of your file before pushing.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ NOTE: *Please avoid opening issues asking to be "assigned" to a particular algor

- Ask any question about how to use the repository in the [TheAlgorithms room in GITTER](https://gitter.im/TheAlgorithms/community?source=orgpage#) or [open a new issue](https://github.com/TheAlgorithms/Java/issues/new)

:+1::tada: That's all you need to know about the process now it's your turn to help us improve the repository, thank you again! :+1::tada:
:+1::tada: That's all you need to know about the process now it's your turn to help us improve the repository, thank you again! :+1::tada: