Skip to content

Commit 5e4730e

Browse files
authored
fix: faulty click area because of padding on invalid element (#115)
* fix(select): faulty click area with padding on invalid DOM element fixes #111. shift the padding from container to sub-elements like search input and single-value. introduce --vs-multi-value-margin for multi-value "padding", making gap unused * fix(docs): update CSS variables on styling page
1 parent 94347fc commit 5e4730e

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

docs/styling.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,9 @@ List of available CSS variables (pulled from the demo):
5252
--vs-option-disabled-color: #f4f4f5;
5353
--vs-option-disabled-text-color: #52525b;
5454

55-
--vs-multi-value-gap: 4px;
55+
--vs-multi-value-gap: 0px;
5656
--vs-multi-value-padding: 4px;
57+
--vs-multi-value-margin: 4px 0px 4px 6px;
5758
--vs-multi-value-font-size: 14px;
5859
--vs-multi-value-font-weight: 400;
5960
--vs-multi-value-line-height: 1;

src/Select.vue

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -536,8 +536,9 @@ onBeforeUnmount(() => {
536536
--vs-option-disabled-color: #f4f4f5;
537537
--vs-option-disabled-text-color: #52525b;
538538
539-
--vs-multi-value-gap: 4px;
539+
--vs-multi-value-gap: 0px;
540540
--vs-multi-value-padding: 4px;
541+
--vs-multi-value-margin: 4px 0px 4px 6px;
541542
--vs-multi-value-font-size: 14px;
542543
--vs-multi-value-font-weight: 400;
543544
--vs-multi-value-line-height: 1;
@@ -602,7 +603,6 @@ onBeforeUnmount(() => {
602603
align-items: center;
603604
flex-basis: 100%;
604605
flex-grow: 1;
605-
padding: var(--vs-padding);
606606
607607
&.multi {
608608
gap: var(--vs-multi-value-gap);
@@ -612,6 +612,7 @@ onBeforeUnmount(() => {
612612
.single-value {
613613
display: flex;
614614
align-items: center;
615+
padding: var(--vs-padding);
615616
font-size: var(--vs-font-size);
616617
font-weight: var(--vs-font-weight);
617618
font-family: var(--vs-font-family);
@@ -626,7 +627,7 @@ onBeforeUnmount(() => {
626627
align-items: center;
627628
gap: var(--vs-multi-value-gap);
628629
padding: var(--vs-multi-value-padding);
629-
margin: 0;
630+
margin: var(--vs-multi-value-margin);
630631
border: 0;
631632
font-size: var(--vs-multi-value-font-size);
632633
font-weight: var(--vs-multi-value-font-weight);
@@ -653,6 +654,7 @@ onBeforeUnmount(() => {
653654
padding: 0;
654655
border: 0;
655656
background: none;
657+
padding: var(--vs-padding);
656658
font-size: var(--vs-font-size);
657659
font-family: var(--vs-font-family);
658660
line-height: var(--vs-line-height);

0 commit comments

Comments
 (0)