Skip to content

fix: faulty click area because of padding on invalid element #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

TotomInc
Copy link
Owner

  • Shift the padding from container (.value-container) into sub-elements like .search-input and .single-value
  • Introduce --vs-multi-value-margin CSS variable to handle the lack of padding on the parent container for multi-value mode.
    • Makes --vs-multi-value-gap unused (0px) but still available as a CSS variable for potential edge-cases.

Fixes #111

fixes #111. shift the padding from container to sub-elements like search input and single-value. introduce --vs-multi-value-margin for multi-value "padding", making gap unused
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue3-select-component ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 2:01pm

@TotomInc TotomInc merged commit 5e4730e into development Sep 22, 2024
2 checks passed
@TotomInc TotomInc deleted the fix/input-padding branch September 23, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant