Skip to content

Faulty click area with extended padding #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdrianFahrbach opened this issue Aug 30, 2024 · 5 comments
Closed

Faulty click area with extended padding #111

AdrianFahrbach opened this issue Aug 30, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@AdrianFahrbach
Copy link

The padding of the field is currently applied to the parent of the input element.
This means that with increased padding, only the inner part of the field (which is the actual input element) is clickable.

In the screenshot below I increased the padding slightly and only approximately the blue area is clickable:

CleanShot 2024-08-30 at 21 23 45@2x
@TotomInc TotomInc added the bug Something isn't working label Sep 19, 2024
@TotomInc
Copy link
Owner

TotomInc commented Sep 19, 2024

I'll try to work on this one, but it requires a lot of changes in the structure of the DOM and potentially the styles too (including CSS variables).

It takes a bit of time to do it right, without introducing a lot of breaking changes 😅

@AdrianFahrbach
Copy link
Author

I guess an easy solution could be negative margin width padding on the input?
Not quite sure, but maybe that works without major changes to the DOM.

TotomInc added a commit that referenced this issue Sep 19, 2024
fixes #111. shift the padding from container to sub-elements like search input and single-value. introduce --vs-multi-value-margin for multi-value "padding", making gap unused
@TotomInc
Copy link
Owner

I believe I've found a great workaround without shaking the entire DOM structure. It introduce a new CSS variable too.
If you have some time to test the PR locally, that would be awesome (clone repo w/ correct branch, npm i and run npm run dev:playground) 🙏

@AdrianFahrbach
Copy link
Author

I will try to take a look at it on the weekend!
Thank you for adjusting this!

@TotomInc
Copy link
Owner

Released on v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants