-
-
Notifications
You must be signed in to change notification settings - Fork 530
fix: drag & drop issues #1458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: drag & drop issues #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great fix that actually gets rid of the hacky settimeout!
YousefED
reviewed
Feb 24, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 additional issues with drag & drop that we didn't previously catch:
dragend
event fires, and not adrop
. Since we only clearview.dragging
on drop events, BlockNote will throw an error the next time the user attempts to drag a block, as it will think that a block is already being dragged. Therefore, this has been fixed by makingview.dragging
get cleared ondragend
events instead.paste
ordrop
events), theUniqueID
plugin setstransformPasted = true
. This signals that any pasted blocks should have their IDs reset & re-generated. After the IDs are reset,transformPasted
is reset back tofalse
. However,transformPasted
doesn't get called at all when external content, such as files, is pasted. This means that if external content is pasted, it remainstrue
for any subsequent drop events, causing errors as the dragged block has no ID. This has been changed so thattransformPasted
is always set totrue
orfalse
before the subsequentpaste
ordrop
.Closes #1444
Closes #1451
Closes #1382