Skip to content

fix: In-scene placed NetworkObjects getting destroyed if early disconnect #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2024
Merged

fix: In-scene placed NetworkObjects getting destroyed if early disconnect #2923

merged 5 commits into from
May 14, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented May 13, 2024 •
edited
Loading

This PR resolves an issue where a client could destroy in-scene placed NetworkObjects if it failed to connect to a session.

fix: #2917
fix: #1670
fix: #1809

Changelog

  • Fixed: Issue where in-scene placed NetworkObjects could be destroyed if a client disconnects early and/or before approval.

Testing and Documentation

  • Added InScenePlacedNetworkObjectClientTests.DespawnAndDestroyNetworkObjects integration test.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
1c43238 
Fixes an issue where in-scene placed NetworkObjects could be destroyed if a connection failed.
@NoelStephensUnity
updte
e0e67ec 
adding changelog entry
@NoelStephensUnity
update
63ca5c0 
changelog and associated PR number
NoelStephensUnity added a commit that referenced this pull request May 13, 2024
@NoelStephensUnity
fix
95062d7 
up-port of #2923 fix for in-scene placed NetworkObjects getting destroyed if a client disconnects early.
@NoelStephensUnity NoelStephensUnity mentioned this pull request May 13, 2024
Merged
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review May 13, 2024 17:38
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 13, 2024 17:38
@NoelStephensUnity
test
dcd7024 
Adding test to validate fix
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 14, 2024 13:30
NoelStephensUnity added a commit that referenced this pull request May 14, 2024
@NoelStephensUnity
fix: In-scene placed NetworkObjects getting destroyed if early discon…
4e35f84 
…nect (up-port) (#2924)

* fix

up-port of #2923 fix for in-scene placed NetworkObjects getting destroyed if a client disconnects early.

* test

adding test to validate fix

* test fix

Fixing issue of checking HasAuthority via NetworkObject as opposed to NetworkBehaviour
@NoelStephensUnity NoelStephensUnity merged commit 1644801 into develop May 14, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/in-scene-placed-destroyed-if-early-disconnect branch May 14, 2024 14:50
@NaolShow NaolShow mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlucas-unity samlucas-unity samlucas-unity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NoelStephensUnity @samlucas-unity