Skip to content

fix: In-scene placed NetworkObjects getting destroyed if early disconnect (up-port) #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2024
Merged

fix: In-scene placed NetworkObjects getting destroyed if early disconnect (up-port) #2924

merged 5 commits into from
May 14, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented May 13, 2024 •
edited
Loading

This is an up-port of fix #2923

Changelog

  • Fixed: Issue where in-scene placed NetworkObjects could be destroyed if a client disconnects early and/or before approval.

Testing and Documentation

  • Added InScenePlacedNetworkObjectClientTests.DespawnAndDestroyNetworkObjects integration test.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
95062d7 
up-port of #2923 fix for in-scene placed NetworkObjects getting destroyed if a client disconnects early.
@NoelStephensUnity
Update CHANGELOG.md
0bcd77e
@NoelStephensUnity NoelStephensUnity changed the base branch from develop to develop-2.0.0 May 13, 2024 17:36
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review May 13, 2024 17:38
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 13, 2024 17:38
@NoelStephensUnity
test
9c9c3e3 
adding test to validate fix
@NoelStephensUnity
test fix
8cfd97e 
Fixing issue of checking HasAuthority via NetworkObject as opposed to NetworkBehaviour
@NoelStephensUnity NoelStephensUnity merged commit 4e35f84 into develop-2.0.0 May 14, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/in-scene-placed-destroyed-if-early-disconnect-up-port branch May 14, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlucas-unity samlucas-unity samlucas-unity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @samlucas-unity