fix: Realtime Network Stats Monitor Not Displaying RPC Metrics in Release Builds #2980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluong6
approved these changes
Jul 19, 2024
NoelStephensUnity
deleted the
fix/rnsm-rpc-stats-not-present-in-release-builds
branch
NoelStephensUnity
added a commit
that referenced
this pull request
Jul 19, 2024
NoelStephensUnity
added a commit
that referenced
this pull request
Jul 22, 2024
…ge handling (#2979) * update Adding xml API documentation and tooltips for the `NetworkConfig.NetworkMessageMetrics` and `NetworkConfig.NetworkProfilingMetrics` properties. * update Added a static helper method in `NetworkManager` to handle logging when a serialized type is not yet optimized for distributed authority. * fix This fix includes the up-port of #2980 (RNSM not tracking RPCs in release builds). Fixing the issue where I forgot to add the serialized type for the not optimized warning message update.
NoelStephensUnity
added a commit
that referenced
this pull request
Jul 29, 2024
* update Updating NGO to v2.0.0-pre.3 Updating UTP dependency to v2.3.0 Updating manifest to current dependencies Updating project version to 6000.0.10f1 * chore: 2.0.0-pre.3 additional last minute updates (#2978) * update missed actually updating the version. * update Added `UnityTransport.GetNetworkDriver` and `UnityTransport.GetLocalEndpoint` methods. * update Updating changelog file. * fix: metrics tooltips and serialized type non optimized warning message handling (#2979) * update Adding xml API documentation and tooltips for the `NetworkConfig.NetworkMessageMetrics` and `NetworkConfig.NetworkProfilingMetrics` properties. * update Added a static helper method in `NetworkManager` to handle logging when a serialized type is not yet optimized for distributed authority. * fix This fix includes the up-port of #2980 (RNSM not tracking RPCs in release builds). Fixing the issue where I forgot to add the serialized type for the not optimized warning message update. * fix: deferred despawn gc allocation (#2983) * fix Remove GC alloc when creating list for deferred despawn. * update adding log entry for fix. * update adding PR for the fix * chore: Anticipated not supported warning (#2982) chore notify user that this component is not supported in distributed authority mode * fix: allow clients to set client synchronization mode distributed authority (#2985) * fix Allow clients to set client synchronization mode when in distributed authority mode since clients can be promoted to session owner. * test apply same rules for the integration test version of the scene handler * update adding change log entry * chore making a new unreleased changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding UNITY_MP_TOOLS_NET_STATS_MONITOR_ENABLED_IN_RELEASE to all of the various dependencies required to enable RNSM tracking of RPC messages.
MTTB-30
Changelog
Testing and Documentation