Skip to content

fix: NetworkAnimator parameter writebuffer limits causes exception #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 21, 2024

This PR resolves the issue of exceeding the legacy parameter limitations defined within NetworkAnimator. Now, NetworkAnimator calculates how much space it needs to allocate to handle parameter serialization based on the Animator's defined parameters.

fix: #3095

Changelog

  • Fixed: Issue where NetworkAnimator would statically allocate write buffer space for Animator parameters that could cause a write error if the number of parameters exceeded the space allocated.

Testing and Documentation

  • No tests were added.
  • No documentation changes or additions were necessary.

Pre-calculate the required parameter write size needed as opposed to using the legacy constant value.
Decided this all could be handled during the Awake method with no need to pre-calculate during validation. Also made adjustments to have a more precise calculation for the size needed.
Adding change log entry
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 21, 2024 22:00
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 21, 2024 22:00
@NoelStephensUnity NoelStephensUnity merged commit a115c83 into develop-2.0.0 Oct 21, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networkanimator-parameter-writebuffer-limit branch October 21, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant