fix: NetworkAnimator parameters writebuffer is limited [backport] #3124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlucas-unity
approved these changes
Nov 18, 2024
NoelStephensUnity
deleted the
fix/networkanimator-parameter-writebuffer-limit-backport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #3108.
This PR resolves the issue of exceeding the legacy parameter limitations defined within
NetworkAnimator. Now,NetworkAnimatorcalculates how much space it needs to allocate to handle parameter serialization based on theAnimator's defined parameters.Changelog
NetworkAnimatorwould statically allocate write buffer space forAnimatorparameters that could cause a write error if the number of parameters exceeded the space allocated.Testing and Documentation