Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate old ConstraintAccordion and point to new version #9613

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Mar 25, 2025

About the changes

Code for constraint accordion was copy-pasted before previous improvement. Old version is still in use for Segments. When we get to improving constraint editing we should rebuild segments editing, without use of this code.

Internal ticket: issue/1-3536

Copy link

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 4:41pm

Copy link
Contributor

github-actions bot commented Mar 25, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the right thing here be to move it into a "LegacyConstraintAccordion" folder? And I'm not sure I understand the linear ticket:

There is a new one, since before this project. Old one is used only on segments.

Are you saying that even before the project, there was a different constraint accordion in use somewhere? What happened to it; have we replaced it in this project? So now we have three? (this one, the other old one, and the new one?)

@Tymek
Copy link
Member Author

Tymek commented Mar 27, 2025

Yes, before current project there where 2 constraint accordion copies in use. We still have 2. Old one is used in segments, but helper functions from it are used in many other places unfortunately. For flag facelift we rebuilt things in a newer version.

@thomasheartman
Copy link
Contributor

Great! Do we have a path forward for removing this component completely? Or is it too tangled up for now?

@Tymek
Copy link
Member Author

Tymek commented Apr 1, 2025

Great! Do we have a path forward for removing this component completely? Or is it too tangled up for now?

Best time to handle it will be if(/when?) we refactor Segments-Edit page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved PRs
Development

Successfully merging this pull request may close these issues.

2 participants