Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate old ConstraintAccordion and point to new version #9613

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { SidebarModal } from 'component/common/SidebarModal/SidebarModal';
import { useSegments } from 'hooks/api/getters/useSegments/useSegments';
import { FeatureStrategyForm } from '../../../../feature/FeatureStrategy/FeatureStrategyForm/FeatureStrategyForm';
import { NewStrategyVariants } from 'component/feature/StrategyTypes/NewStrategyVariants';
import { constraintId } from 'component/common/ConstraintAccordion/ConstraintAccordionList/createEmptyConstraint';
import { constraintId } from 'component/common/LegacyConstraintAccordion/ConstraintAccordionList/createEmptyConstraint';
import { v4 as uuidv4 } from 'uuid';

interface IEditChangeProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type {
} from 'component/changeRequest/changeRequest.types';
import { useSegment } from 'hooks/api/getters/useSegment/useSegment';
import { SegmentDiff, SegmentTooltipLink } from '../../SegmentTooltipLink';
import { ConstraintAccordionList } from 'component/common/ConstraintAccordion/ConstraintAccordionList/ConstraintAccordionList';
import { ConstraintAccordionList } from 'component/common/LegacyConstraintAccordion/ConstraintAccordionList/ConstraintAccordionList';
import { ChangeOverwriteWarning } from './ChangeOverwriteWarning/ChangeOverwriteWarning';

const ChangeItemCreateEditWrapper = styled(Box)(({ theme }) => ({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { ComponentProps, FC, ReactNode } from 'react';
import { StrategyEvaluationItem } from '../StrategyEvaluationItem/StrategyEvaluationItem';
import type { ConstraintSchema } from 'openapi';
import { formatOperatorDescription } from 'component/common/ConstraintAccordion/ConstraintOperator/formatOperatorDescription';
import { formatOperatorDescription } from 'component/common/LegacyConstraintAccordion/ConstraintOperator/formatOperatorDescription';
import { StrategyEvaluationChip } from '../StrategyEvaluationChip/StrategyEvaluationChip';
import { styled, Tooltip } from '@mui/material';
import { Truncator } from 'component/common/Truncator/Truncator';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ interface IConstraintAccordionProps {
onSave?: (constraint: IConstraint) => void;
}

/**
* @deprecated use `component/common/NewConstraintAccordion/NewConstraintAccordion`
*/
export const ConstraintAccordion = ({
constraint,
compact = false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ const StyledAccordionDetails = styled(AccordionDetails)(({ theme }) => ({
padding: 0,
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionEdit = ({
constraint,
compact,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ const StyledRightButton = styled(Button)(({ theme }) => ({
minWidth: '125px',
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionEditBody: React.FC<
IConstraintAccordionBody
> = ({ localConstraint, children, triggerTransition, setAction, onSubmit }) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ const StyledHeader = styled('h3')(({ theme }) => ({
marginBottom: theme.spacing(0.5),
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintFormHeader: React.FC<
React.HTMLAttributes<HTMLDivElement>
> = ({ children, ...rest }) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ const StyledWrapper = styled('div')(({ theme }) => ({
gap: theme.spacing(1),
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const DateSingleValue = ({
setValue,
value,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ const useStyles = makeStyles()((theme) => ({

const ENTER = 'Enter';

/**
* @deprecated use NewConstraintAccordion components
*/
export const FreeTextInput = ({
values,
removeValue,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ export const LegalValueLabel = ({ legal, control }: ILegalValueTextProps) => {
);
};

/**
* @deprecated use NewConstraintAccordion components
*/
export const filterLegalValues = (
legalValues: ILegalValue[],
filter: string,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ const resolveLegalValues = (
};
};

/**
* @deprecated use NewConstraintAccordion components
*/
export const ResolveInput = ({
input,
contextDefinition,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { useEffect, useState } from 'react';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import { Alert, Checkbox, styled } from '@mui/material';
import { useThemeStyles } from 'themes/themeStyles';
import { ConstraintValueSearch } from 'component/common/ConstraintAccordion/ConstraintValueSearch/ConstraintValueSearch';
import { ConstraintValueSearch } from 'component/common/LegacyConstraintAccordion/ConstraintValueSearch/ConstraintValueSearch';
import { ConstraintFormHeader } from '../ConstraintFormHeader/ConstraintFormHeader';
import type { ILegalValue } from 'interfaces/context';
import {
Expand Down Expand Up @@ -60,6 +60,9 @@ const StyledValuesContainer = styled('div')(({ theme }) => ({
overflow: 'auto',
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const RestrictiveLegalValues = ({
data,
values,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type React from 'react';
import { useState } from 'react';
import { ConstraintFormHeader } from '../ConstraintFormHeader/ConstraintFormHeader';
import { FormControl, RadioGroup, Radio, Alert } from '@mui/material';
import { ConstraintValueSearch } from 'component/common/ConstraintAccordion/ConstraintValueSearch/ConstraintValueSearch';
import { ConstraintValueSearch } from 'component/common/LegacyConstraintAccordion/ConstraintValueSearch/ConstraintValueSearch';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import { useThemeStyles } from 'themes/themeStyles';
import type { ILegalValue } from 'interfaces/context';
Expand All @@ -26,6 +26,9 @@ interface ISingleLegalValueProps {
constraintValue: string;
}

/**
* @deprecated use NewConstraintAccordion components
*/
export const SingleLegalValue = ({
setValue,
value,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ const useStyles = makeStyles()((theme) => ({
},
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const SingleValue = ({
setValue,
value,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ type Validator =
| 'STRING_ARRAY_VALIDATOR'
| 'DATE_VALIDATOR';

/**
* @deprecated use NewConstraintAccordion components
*/
export const useConstraintInput = ({
contextDefinition,
localConstraint,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type { IConstraint } from 'interfaces/strategy';

import useUnleashContext from 'hooks/api/getters/useUnleashContext/useUnleashContext';
import GeneralSelect from 'component/common/GeneralSelect/GeneralSelect';
import { ConstraintIcon } from 'component/common/ConstraintAccordion/ConstraintIcon';
import { ConstraintIcon } from 'component/common/LegacyConstraintAccordion/ConstraintIcon';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import {
dateOperators,
Expand All @@ -15,7 +15,7 @@ import { oneOf } from 'utils/oneOf';
import type React from 'react';
import { useEffect, useState } from 'react';
import type { Operator } from 'constants/operators';
import { ConstraintOperatorSelect } from 'component/common/ConstraintAccordion/ConstraintOperatorSelect';
import { ConstraintOperatorSelect } from 'component/common/LegacyConstraintAccordion/ConstraintOperatorSelect';
import {
operatorsForContext,
CURRENT_TIME_CONTEXT_FIELD,
Expand Down Expand Up @@ -87,6 +87,9 @@ const StyledHeaderText = styled('p')(({ theme }) => ({
},
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionEditHeader = ({
compact,
localConstraint,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ interface CaseSensitiveButtonProps {
setCaseInsensitive: () => void;
}

/**
* @deprecated use NewConstraintAccordion components
*/
export const CaseSensitiveButton = ({
localConstraint,
setCaseInsensitive,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ interface InvertedOperatorButtonProps {
setInvertedOperator: () => void;
}

/**
* @deprecated use NewConstraintAccordion components
*/
export const InvertedOperatorButton = ({
localConstraint,
setInvertedOperator,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import { styled } from '@mui/system';
import { IconButton } from '@mui/material';

/**
* @deprecated use NewConstraintAccordion components
*/
export const StyledToggleButtonOff = styled(IconButton)(({ theme }) => ({
width: '28px',
minWidth: '28px',
Expand All @@ -19,6 +22,9 @@ export const StyledToggleButtonOff = styled(IconButton)(({ theme }) => ({
},
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const StyledToggleButtonOn = styled(IconButton)(({ theme }) => ({
width: '28px',
minWidth: '28px',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ const StyledHeaderActions = styled('div')(({ theme }) => ({
},
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionHeaderActions = ({
onEdit,
onDelete,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ import {
import { Button, styled, Tooltip } from '@mui/material';
import HelpOutline from '@mui/icons-material/HelpOutline';
import type { IConstraint } from 'interfaces/strategy';
import { ConstraintAccordion } from 'component/common/ConstraintAccordion/ConstraintAccordion';
import { ConstraintAccordion } from 'component/common/LegacyConstraintAccordion/ConstraintAccordion';
import produce from 'immer';
import useUnleashContext from 'hooks/api/getters/useUnleashContext/useUnleashContext';
import { type IUseWeakMap, useWeakMap } from 'hooks/useWeakMap';
import { objectId } from 'utils/objectId';
import { createEmptyConstraint } from 'component/common/ConstraintAccordion/ConstraintAccordionList/createEmptyConstraint';
import { createEmptyConstraint } from 'component/common/LegacyConstraintAccordion/ConstraintAccordionList/createEmptyConstraint';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import { StrategySeparator } from 'component/common/StrategySeparator/LegacyStrategySeparator';

Expand Down Expand Up @@ -104,6 +104,9 @@ export const useConstraintAccordionList = (
return { onAdd, state, context };
};

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionList = forwardRef<
IConstraintAccordionListRef | undefined,
IConstraintAccordionListProps
Expand Down Expand Up @@ -183,6 +186,9 @@ interface IConstraintList {
state: IUseWeakMap<IConstraint, IConstraintAccordionListItemState>;
}

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintList = forwardRef<
IConstraintAccordionListRef | undefined,
IConstraintList
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ const StyledWrapper = styled('div')({
width: '100%',
});

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionView = ({
constraint,
onEdit,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ const StyledValueContainer = styled('div')(({ theme }) => ({
overflowY: 'auto',
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionViewBody = ({
constraint,
}: IConstraintAccordionViewBodyProps) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ const StyledChip = styled(Chip)(({ theme }) => ({
margin: theme.spacing(0, 1, 1, 0),
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const MultipleValues = ({ values }: IMultipleValuesProps) => {
const [filter, setFilter] = useState('');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ const StyledChip = styled(Chip)(({ theme }) => ({
margin: theme.spacing(0, 1, 1, 0),
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const SingleValue = ({ value, operator }: ISingleValueProps) => {
if (!value) return null;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ConstraintIcon } from 'component/common/ConstraintAccordion/ConstraintIcon';
import { ConstraintIcon } from 'component/common/LegacyConstraintAccordion/ConstraintIcon';
import type { IConstraint } from 'interfaces/strategy';
import { ConstraintAccordionViewHeaderInfo } from './ConstraintAccordionViewHeaderInfo';
import { ConstraintAccordionHeaderActions } from '../../ConstraintAccordionHeaderActions/ConstraintAccordionHeaderActions';
Expand Down Expand Up @@ -27,6 +27,9 @@ const StyledContainer = styled('div')(({ theme }) => ({
},
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionViewHeader = ({
constraint,
onEdit,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ interface ConstraintAccordionViewHeaderMetaInfoProps {
maxLength?: number;
}

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionViewHeaderInfo = ({
constraint,
singleValue,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ const StyledHeaderValuesExpand = styled('p')(({ theme }) => ({
},
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionViewHeaderMultipleValues = ({
constraint,
expanded,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ const StyledHeaderValuesContainerWrapper = styled('div')(({ theme }) => ({
margin: 'auto 0',
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintAccordionViewHeaderSingleValue = ({
constraint,
allowExpand,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ const StyledHeaderConstraintContainer = styled('div')(({ theme }) => ({
},
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintViewHeaderOperator = ({
constraint,
disabled = false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ const StyledPrefixIconWrapper = styled(StyledIconWrapperBase)(({ theme }) => ({
borderBottomRightRadius: 0,
}));

/**
* @deprecated use NewConstraintAccordion components
*/
export const StyledIconWrapper = forwardRef<
HTMLDivElement,
{ isPrefix?: boolean; children?: ReactNode }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ interface IConstraintIconProps {
disabled?: boolean;
}

/**
* @deprecated use NewConstraintAccordion components
*/
export const ConstraintIcon: VFC<IConstraintIconProps> = ({
compact,
disabled,
Expand Down
Loading