fix: add Project and Playground icons for command bar #9677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
approved these changes
Apr 2, 2025
| const icons: Record<string, typeof SvgIcon> = { | ||
| const icons: Record< | ||
| string, | ||
| typeof SvgIcon | FC<ComponentProps<typeof SvgIcon>> |
There was a problem hiding this comment.
What's this signature change about?
There was a problem hiding this comment.
Project icon is a different type, because it's a custom SVG, not from MUI. This probably could be aligned, but is not worth the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Updating
IconRenderercomponent in theNavigationSidebar. It will fix icons not showing up for command bar search results.