Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Project and Playground icons for command bar #9677

Merged
merged 1 commit into from
Apr 2, 2025
Merged

fix: add Project and Playground icons for command bar #9677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions frontend/src/component/layout/MainLayout/NavigationSidebar/IconRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { ComponentProps, FC } from 'react';
import EmptyIcon from '@mui/icons-material/CheckBoxOutlineBlankOutlined';
import type SvgIcon from '@mui/material/SvgIcon/SvgIcon';
import ApplicationsIcon from '@mui/icons-material/AppsOutlined';
Expand Down Expand Up @@ -29,10 +30,14 @@ import GitHubIcon from '@mui/icons-material/GitHub';
import LibraryBooksIcon from '@mui/icons-material/LibraryBooks';
import FactCheckOutlinedIcon from '@mui/icons-material/FactCheckOutlined';
import PersonalDashboardIcon from '@mui/icons-material/DashboardOutlined';
import type { FC } from 'react';
import { ProjectIcon } from 'component/common/ProjectIcon/ProjectIcon';
import PlaygroundIcon from '@mui/icons-material/AutoFixNormal';

// TODO: move to routes
const icons: Record<string, typeof SvgIcon> = {
const icons: Record<
string,
typeof SvgIcon | FC<ComponentProps<typeof SvgIcon>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this signature change about?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project icon is a different type, because it's a custom SVG, not from MUI. This probably could be aligned, but is not worth the time.

> = {
'/search': SearchIcon,
'/applications': ApplicationsIcon,
'/context': ContextFieldsIcon,
Expand Down Expand Up @@ -60,6 +65,8 @@ const icons: Record<string, typeof SvgIcon> = {
'/history': EventLogIcon,
'/release-templates': FactCheckOutlinedIcon,
'/personal': PersonalDashboardIcon,
'/projects': ProjectIcon,
'/playground': PlaygroundIcon,
GitHub: GitHubIcon,
Documentation: LibraryBooksIcon,
};
Expand Down