Skip to content

Visualizations: no data detection needs to be more sophisticated now we have overlay and facet vars #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobular opened this issue Nov 9, 2021 · 3 comments · Fixed by #770
Closed

Visualizations: no data detection needs to be more sophisticated now we have overlay and facet vars #676

bobular opened this issue Nov 9, 2021 · 3 comments · Fixed by #770
Assignees
@bobular @aaronwlsong
Labels
b55 b56 bug Something isn't working
Milestone
EDA ClinEpi Phase 2

Comments

@bobular
Copy link
Member

bobular commented Nov 9, 2021 •
edited
Loading

This is what it should NOT look like:

(GEMS1 beta site, 8/Dec/2021)

A. Empty "No data" facet for a variable (Country) with no missing data. (The overlay variable which does have missing data, is triggering this.)
image

B. Empty "No data" item in overlay variable legend (facet variable is triggering this)
image

Please also test a "Main variable" that has missing data. E.g., "Given stored water for drinking"
@bobular bobular self-assigned this Nov 9, 2021
@bobular bobular mentioned this issue Nov 9, 2021
Merged
@bobular bobular added this to the EDA ClinEpi Phase 2 milestone Nov 15, 2021
@danicahelb danicahelb added b56 bug Something isn't working b55 labels Nov 17, 2021
@bobular
Copy link
Member Author

bobular commented Nov 17, 2021

Hi @danicahelb - this has both b55 and b56 labels! DSR said it was not a showstopper that unintended "No data" overlays and facets might appear in certain edge-cases. I will work on it next, but am concerned that a substantial change in the logical behaviour of visualisations might introduce further bugs this close to release. Your thoughts?

@bobular bobular mentioned this issue Nov 19, 2021
Merged
@bobular
Copy link
Member Author

bobular commented Dec 6, 2021

Just an update to say I am still working on this! It's complicated but I am hopefully arriving at a parsimonious solution soon.

@bobular bobular mentioned this issue Dec 7, 2021
Merged
@moontrip moontrip mentioned this issue Dec 8, 2021
Merged
@aaronwlsong
Copy link

aaronwlsong commented Dec 16, 2021 •
edited
Loading

Looks good now, closing ticket.

The case 1 : "No data" in overlay variable
image
The case 2. "No data" item in facet variable
image
The case 3. "No data" in Main variable
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobular bobular

@aaronwlsong aaronwlsong

Labels
b55 b56 bug Something isn't working
Projects
None yet
Milestone
EDA ClinEpi Phase 2
Development

Successfully merging a pull request may close this issue.

More sophisticated showMissing behaviour and reused more entity counts VEuPathDB/web-eda
3 participants
@bobular @danicahelb @aaronwlsong