Simpify PassRunner.add() and automatically parallelize parallel functions #2242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... this makes everything super-slow. It's not the parallelism - removing the parallel part from the pass.h changes has no effect. No idea what's going on here... |
|
Nevermind, there was something wrong with that checkout - even though cmake indicated it was a release build, and even though I rebuilt... it was as slow as a debug build. Building in a new directory works. This PR should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change here is in
pass.h, everything else is changes to work with the new API.The
add("name")remains as before, while the weird variadicadd(..)which constructed the pass now just gets astd::unique_ptrof a pass. This also makes the memory management internally fully automatic. And it makes it trivial to parallelizeWalkerPass::runon parallel passes.As a benefit, this allows removing a lot of code since in many cases there is no need to create a new pass runner, and running a pass can be just a single line.