Skip to content

Re-land #2235 with fixes #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 21, 2019
Merged

Conversation

tlively
Copy link
Member

@tlively tlively commented Jul 20, 2019

#2242 had exposed the bug that the Trapper pass was defining walkFunction when it should have been defining doWalkFunction.

ReFinalize().walkFunctionInModule(func, getModule());
}
}
bool isFunctionParallel() override { return true; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency with other code please put these last two functions at the top.

@tlively tlively merged commit beef3e9 into WebAssembly:master Jul 21, 2019
@tlively tlively deleted the unreachable-bulk-mem branch April 24, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants