Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Consistency with non-trapping truncate proposal #25

Closed
AndrewScheidecker opened this issue Dec 2, 2017 · 3 comments
Closed

Consistency with non-trapping truncate proposal #25

AndrewScheidecker opened this issue Dec 2, 2017 · 3 comments

Comments

@AndrewScheidecker
Copy link
Contributor

I noticed that the proposed non-trapping truncate instructions put the :sat in a different place in the instruction name from the SIMD proposal:
i32x4.trunc_s/f32x4:sat vs i32.trunc_s:sat/f32

I personally prefer the style of the non-trapping truncate proposal (i32.trunc_s:sat/f32), but mostly I'd just like for it to be consistent between the two proposals.
@rossberg
Copy link
Member

rossberg commented Dec 4, 2017

Agreed. The latter is more consistent (though still not exactly pretty).

@stoklund
Copy link
Contributor

stoklund commented Dec 4, 2017

Works for me

AndrewScheidecker added a commit to AndrewScheidecker/WebAssembly-simd that referenced this issue Dec 6, 2017
@AndrewScheidecker
Change saturating truncation operators to place the ":sat" modifier i…
4baff06 
…mmediately after the trunc_u or trunc_s, instead of after the source type

e.g. i32x4.trunc_s:sat/f32x4 instead of i32.trunc_s/f32x4:sat
Resolves WebAssembly#25
@AndrewScheidecker AndrewScheidecker mentioned this issue Dec 6, 2017
Closed
@dtig
Copy link
Member

dtig commented Dec 17, 2018

Closing in favor of the general discussion happening here - WebAssembly/spec#884.

@dtig dtig closed this as completed Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change saturating truncation operator names AndrewScheidecker/WebAssembly-simd
4 participants
@AndrewScheidecker @rossberg @dtig @stoklund