This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Change saturating truncation operator names #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmediately after the trunc_u or trunc_s, instead of after the source type e.g. i32x4.trunc_s:sat/f32x4 instead of i32.trunc_s/f32x4:sat Resolves WebAssembly#25
|
This was never merged, and seems suspiciously similar to #40, and it might appear that both should be closed until https://github.com/WebAssembly/nontrapping-float-to-int-conversions/ is resolved (cc @sunfishcode ) offtopic: Are there any triage meetings for the issues / PRs in this repo ? |
|
I'm not sure why this PR wasn't merged after it was approved - it makes sense to close it and track this through the more recent issue. AFAIK, there are no triage meetings for issues/PRs in this repository, though an issue that needs resolution could be discussed in one of the regular CG Meetings. |
|
We ended up discussing a more general renaming here: WebAssembly/spec#884 |
|
Closing as this issue is being discussed here - WebAssembly/spec#884 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes saturating truncation operators to place the ":sat" modifier immediately after the trunc_u or trunc_s, instead of after the source type. e.g:
i32x4.trunc_s:sat/f32x4instead ofi32.trunc_s/f32x4:satThis resolves #25