This repository was archived by the owner on Dec 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Add SIMD instructions to syntax #271
Merged
ngzhian
merged 20 commits into
WebAssembly:master
from
ngzhian:add-simd-structure-instructions
Aug 25, 2020
Merged
Add SIMD instructions to syntax #271
ngzhian
merged 20 commits into
WebAssembly:master
from
ngzhian:add-simd-structure-instructions
Aug 25, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56496c8
to
64afd26
Compare
binji
reviewed
Jul 24, 2020
rossberg
reviewed
Jul 27, 2020
binji
reviewed
Jul 29, 2020
rossberg
reviewed
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for separating specification from explanation.
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
ngzhian
commented
Aug 5, 2020
ngzhian
commented
Aug 5, 2020
I noticed that some instructions that take immediates were not properly specified:
Introduced a new production |
ngzhian
commented
Aug 7, 2020
rossberg
reviewed
Aug 10, 2020
Co-authored-by: Andreas Rossberg <[email protected]>
rossberg
approved these changes
Aug 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes are defining:
Unfortunately, the definition of instructions aren't as clean as the existing ones, due to high asymmetry (see https://github.com/WebAssembly/simd/blob/master/proposals/simd/NewOpcodes.md for an overview).
This leads to a lot of specific i8x16, i16x8, i32x4 instructions defined (since i64x2 has to be left out).
I also tweaked the paragraph describing comparisons, to indicate that comparisons can return a boolean, or return a value of the same type, because the SIMD comparisons return S128. I'm not sure if this tweak should stick, we can also classify SIMD comparisons as Binary instructions, but that's confusing too. I guess I don't know if these subcategories are meant to classify instructions by "the kind of things they do" or "the type signature"?
See https://www.ngzhian.com/simd/core/syntax/instructions.html for a preview.