Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Rename truncations to avoid colon in name #40

Closed
wants to merge 1 commit into from
Closed

Conversation

tlively
Copy link
Member

@tlively tlively commented Sep 21, 2018

Having colons in instruction names would require special handling in
existing assemblers, which seems like unnecessary extra work.

Having colons in instruction names would require special handling in
existing assemblers, which seems like unnecessary extra work.
@sunfishcode
Copy link
Member

These names correspond to the names added in https://github.com/WebAssembly/nontrapping-float-to-int-conversions/. LLVM already uses these names. As it happens, those names are not actually final yet, and are under discussion in WebAssembly/nontrapping-float-to-int-conversions#4. I'm not attached to the ':' character, however I would like to see if we can find a logical naming scheme for these names, as this will likely be a pattern that many future opcodes will follow.

@tlively
Copy link
Member Author

tlively commented Sep 21, 2018

Thanks, @sunfishcode. I wasn't aware of the names in the nontrapping conversions proposal, so I will go chime in over there.

@tlively
Copy link
Member Author

tlively commented Nov 19, 2018

Closing this for now, since it is outdated and the discussion is happening elsewhere.

@tlively tlively closed this Nov 19, 2018
@dtig dtig deleted the no-colons branch September 4, 2019 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants