This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Rename i8x16.any_true to v128.any_true and remove other variants #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accepted in WebAssembly#416. The test code is manually modified (this is not generated code), to always call v128.any_true. The exported function names are unchanged, and no tests are removed, since it is useful to test v128 of different constants.
rossberg
approved these changes
Jan 26, 2021
ngzhian
added a commit
to ngzhian/simd
that referenced
this pull request
Jan 26, 2021
The renaming was accepted in WebAssembly#416. Interpreter was changed in WebAssembly#426. This makes similar changes to the formal text.
ngzhian
added a commit
to ngzhian/simd
that referenced
this pull request
Jan 26, 2021
The renaming was accepted in WebAssembly#416. Interpreter was changed in WebAssembly#426. This makes similar changes to the formal text.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accepted in #416.
The test code is manually modified (this is not generated code), to
always call v128.any_true. The exported function names are unchanged,
and no tests are removed, since it is useful to test v128 of
different constants.
For now, v128.any_true occupies the same binary opcode as i8x16.any_true,
this can change after we finalize the instruction set.