Monkey patch configparser with EfficientParsingError #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subclass `configparser.ParsingError`, overwrite the terribly inefficient `append` method and monkey patch `ParsingError` with `EfficientParsingError`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopes to provide a short-term solution for #136
Changes
🎭 🎭 🎭
configparser.ParsingErrorappendmethodParsingErrorwithEfficientParsingErrorTesting
I ran this on the "take forever"
~250kline file withtimeand it took around 11 seconds, we should probably do solutions 1 or 3 from our discussion as well, eventually, but taking 11 seconds vs. forever is incrementally better.