-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding baseline functionality for benchmark script #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🐑
) | ||
|
||
|
||
def generate_content(separator, length): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@killuazhu , with regards to #136, can you see what changes this code needs to undergo in order to reproduce your performance hit? Even with my sample of 250K lines, it only took ~16s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the convenient links!
After reverting those changes locally, I get these results:
$ scripts/run_performance_tests.py -m LONG_FILE --baseline baseline.json
Generating content...
Running checks...
------------------------------------------------------------
plugin time change
------------------------------------------------------------
All Plugins Timeout exceeded! ▲ 13.9
AWSKeyDetector 1.38776s ▲ 0.02
ArtifactoryDetector 1.87043s ▲ 0.03
Base64HighEntropyString Timeout exceeded! ▲ 27.11
BasicAuthDetector 1.37341s ▼ -0.02
HexHighEntropyString Timeout exceeded! ▲ 27.13
KeywordDetector 2.47949s ▼ -0.02
PrivateKeyDetector 1.85911s -
SlackDetector 1.5571s ▼ -0.06
StripeDetector 1.40493s -
------------------------------------------------------------
Good to know our changes were effective, and that this script would help us identify any further issues in the future!
Example Usage
This allows us to do: