Inconsistent type of resolvedDependenciesGraph
#94
Assignees
Labels
bug
Something isn't working
Comments
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Nov 3, 2022
If a project defines no dependencies python-inspector returns an empty object instead of an empty array [1]. Create a custom deserializer as a workaround to not fail during deserialization. [1]: aboutcode-org/python-inspector#94 Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Nov 3, 2022
If a project defines no dependencies python-inspector returns an empty object instead of an empty array [1]. Create a custom deserializer as a workaround to not fail during deserialization. [1]: aboutcode-org/python-inspector#94 Signed-off-by: Martin Nonnenmacher <[email protected]>
|
@mnonnenmacher thanks for raising this, I am having a look on this. |
TG1999
added a commit
that referenced
this issue
Nov 3, 2022
Reference: #94 Signed-off-by: Tushar Goel <[email protected]>
TG1999
added a commit
that referenced
this issue
Nov 4, 2022
Reference: #94 Signed-off-by: Tushar Goel <[email protected]>
TG1999
added a commit
that referenced
this issue
Nov 4, 2022
Return empty list for resolved dependencies graph in case no dependencies are found #94
|
This is fixed in https://pypi.org/project/python-inspector/0.9.2/ , please check and let us know. |
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Nov 7, 2022
For the release notes see [1]. This version fixes a deserialization issue so upgrade the minimum required version as well [2]. [1]: https://github.com/nexB/python-inspector/blob/main/CHANGELOG.rst#v092 [2]: aboutcode-org/python-inspector#94 Signed-off-by: Martin Nonnenmacher <[email protected]>
|
Thanks @TG1999, the fix works. |
mnonnenmacher
added a commit
to oss-review-toolkit/ort
that referenced
this issue
Nov 7, 2022
For the release notes see [1]. This version fixes a deserialization issue so upgrade the minimum required version as well [2]. [1]: https://github.com/nexB/python-inspector/blob/main/CHANGELOG.rst#v092 [2]: aboutcode-org/python-inspector#94 Signed-off-by: Martin Nonnenmacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the fix for #86 the type of the
resolvedDependenciesGraphproperty is now inconsistent. Usually the property is an array, but if the dependency graph is empty it is an empty object{}instead of an empty array:https://github.com/nexB/python-inspector/blob/0da2e84124fa10de7b2b005240b8de38c0095286/tests/data/setup/no-direct-dependencies-setup.py-expected.json#L84
This makes the deserialization unnecessarily complex.
The text was updated successfully, but these errors were encountered: