PythonInspector: Fix a deserialization issue #6036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a project defines no dependencies python-inspector returns an empty object instead of an empty array [1]. Create a custom deserializer as a workaround to not fail during deserialization. [1]: aboutcode-org/python-inspector#94 Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
pip-empty-dependencies
branch
from
089be93 to
1ac3c74
Compare
sschuberth
reviewed
Nov 3, 2022
| @@ -112,10 +116,19 @@ internal object PythonInspector : CommandLineTool, Logging { | |||
| @Serializable | |||
| internal data class Result( | |||
| @SerialName("files") val projects: List<Project>, | |||
| @SerialName("resolved_dependencies_graph") val resolvedDependenciesGraph: List<ResolvedDependency>, | |||
| @SerialName("resolved_dependencies_graph") | |||
| @Serializable(with = DependencyGraphDeserializer::class) | |||
There was a problem hiding this comment.
Would it make sense to do the changes in this file in a separate commit that can be cleanly reverted once the issue is fixed, but the changes to PipFunTest are kept?
|
The root cause was fixed in the meantime, I will replace this with a python-inspector upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a project defines no dependencies python-inspector returns an empty object instead of an empty array 1. Create a custom deserializer as a workaround to not fail during deserialization.