-
Notifications
You must be signed in to change notification settings - Fork 109
Codebase resource "Name" is not the filename #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This inconsistency is causing problems when updating the application package scanning step with the new Package assembly methods from packagedcode. The assembly methods on different Package handlers look for particular Package manifest files by their filename with extension (e.g. https://github.com/nexB/scancode-toolkit/blob/develop/src/packagedcode/npm.py#L72). Because scancode.io stores the filename without the extension in the |
* Update scancode-toolkit to 31.0.0rc3 #447 * Update expected test results Signed-off-by: Jono Yang <[email protected]>
* Update scancode-toolkit to 31.0.0rc3 #447 * Update expected test results * Update code formatting Signed-off-by: Jono Yang <[email protected]>
* Update scancode-toolkit to 31.0.0rc3 #447 * Update expected test results * Update code formatting Signed-off-by: Jono Yang <[email protected]>
@JonoYang is https://github.com/nexB/scancode.io/compare/package-scanning-update ready for review? |
* Create migration on CodebaseResource to append extension to name, if name does not end with extension * Update exptected test results Signed-off-by: Jono Yang <[email protected]>
* Create migration on CodebaseResource to append extension to name, if name does not end with extension * Update exptected test results Signed-off-by: Jono Yang <[email protected]>
* Create migration on CodebaseResource to append extension to name, if name does not end with extension * Update exptected test results Signed-off-by: Jono Yang <[email protected]>
I found highly surprising that the name field of the CodebaseResource model (and therefore also in the UI) is NOT the actual file name or directory name, but rather has been stripped from it's extension, which is stored in a separate field. What's the rationale for this?
The text was updated successfully, but these errors were encountered: