Adding sorting layer to the compliance alerts #1581

[abanoub-samy-farhan]

I have worked on the bug found in #1581

I have added a sorting layer before returning the list of compliance alerts by using the possible labels found.
If there are any comments, I would love to hear on how I can improve it to be more compatible.
@pombredanne

[abanoub-samy-farhan]

Good morning,

I have made some changes to the code logic and updated the test file to check for the compliance order by severity; please check them out. I would really appreciate your feedback. @pombredanne.

[AyanSinhaMahapatra]

Thanks++ @abanoub-samy-farhan, this works nicely. See comments for some minor nits for your consideration.
Could you also make sure all the tests are passing?

On scanning docker://registry.fedoraproject.org/fedora:41:

[AyanSinhaMahapatra]

Instead of adding a new list here with the values, we should extract the already defined values dict at https://github.com/aboutcode-org/scancode.io/blob/main/scanpipe/models.py#L2200 and use the keys from there.

[abanoub-samy-farhan]

Thanks for the feedback, I have implemented a method in the ComplianceAlertQuerySetMixin class to retrive the order instantly from the queryset

def compliance_alerts_ordered_by_severity(self):
        """
        Return a list of compliance alerts ordered by severity.
        """
        compliance = self.model.Compliance
        return [
            compliance.ERROR.value,
            compliance.WARNING.value,
            compliance.MISSING.value,
        ]

now instead of hard coding a list, I can call this method

    severity_levels = queryset.compliance_alerts_ordered_by_severity()

Kindly, if you would like me to define a global variable or use another method, please inform me.

[AyanSinhaMahapatra]

Could you have the if statement in a new line? This is failing code style checks.

[abanoub-samy-farhan]

Noted I have fixed it