Skip to content

Fix game_rotation_vector initial value #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

TwoTenPvP
Copy link
Contributor

@TwoTenPvP TwoTenPvP commented Dec 15, 2020

Ensures that game_rotation_vector will have a initial value of length 4 to be parsable as a quaternion.

Perhaps it should even be changed to a Identity quaternion?

This should probably also be done for geomagnetic_quaternion

Ensures that game_rotation_vector will have a initial value of length 4 to be parsable as a quaternion.
@ladyada ladyada requested a review from siddacious December 15, 2020 15:54
@siddacious siddacious merged commit 3054fa0 into adafruit:master Dec 21, 2020
@siddacious
Copy link
Contributor

@TwoTenPvP A PR to add an init value for geomagnetic_quaternion would be appreciated! Thanks for your contribution.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 29, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#11 from TwoTenPvP/patch-2
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#10 from TwoTenPvP/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.6.6 from 3.6.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#49 from d-c-d/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.4 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#27 from adafruit/spi_mag_auto_incr

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#5 from mshannon78660/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#24 from ktdreyer/docs-fixes
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#25 from ktdreyer/button-packet-length

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.5.3 from 1.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#33 from ladyada/master
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#32 from adafruit/revert-30-join_paths_instead_of_concat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants