Add extra / in path in case folks forgot it #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jepler merged 1 commit into adafruit:master from ladyada:master

Dec 27, 2020

Member

ladyada commented Dec 27, 2020

fix for #31 and adafruit/Adafruit_Learning_System_Guides#1318


          fix for adafruit#31 and adafruit/Adafruit_Learning_System_Guides#1318

156d52e

ladyada requested a review from a team

December 27, 2020 17:41

FoamyGuy approved these changes

View reviewed changes

Contributor

FoamyGuy left a comment

looks good to me. Tested with simpletest script on PyPortal

jepler approved these changes

View reviewed changes

Contributor

jepler left a comment

Seems fine, doubling up slashes doesn't harm anything. At some point we should implement a path library like desktop python though

jepler merged commit 77f9d3d into adafruit:master

Member Author

ladyada commented Dec 27, 2020

thanks :)

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@644d4b7)

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#11 from TwoTenPvP/patch-2
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#10 from TwoTenPvP/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.6.6 from 3.6.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#49 from d-c-d/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.4 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#27 from adafruit/spi_mag_auto_incr

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#5 from mshannon78660/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#24 from ktdreyer/docs-fixes
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#25 from ktdreyer/button-packet-length

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.5.3 from 1.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#33 from ladyada/master
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#32 from adafruit/revert-30-join_paths_instead_of_concat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet