Skip to content

Updated PyPortal example to work with latest stable CircuitPython #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2019
Merged

Updated PyPortal example to work with latest stable CircuitPython #18

merged 2 commits into from
Aug 20, 2019

Conversation

makermelissa
Copy link
Collaborator

Fixes #17.

@makermelissa makermelissa requested a review from a team August 19, 2019 17:17
tannewt
tannewt reviewed Aug 19, 2019
View reviewed changes
examples/display_text_pyportal.py Outdated

print("fade down")

# splash.pop()
while True:
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wait if the code is done? Isn't it ok to kick to the terminal?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way. It just shows the fade out nicely, but perhaps another delay and then kick back to terminal?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, sounds good.

tannewt
tannewt approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@tannewt tannewt merged commit 13323a0 into adafruit:master Aug 20, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 20, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@9869a7c)
365e2e8 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#18 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to v1.0.1 from v1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#2 from brentru/fix-md5-import

Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 1.0.1 from v1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#4 from jepler/issue3

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_binascii, Adafruit_CircuitPython_hashlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

display_text_pyportal.py outdated
2 participants
@makermelissa @tannewt