adafruit_itertools_extra: Fix import #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import statement incorrectly referred to the package, not the submodule, leading to the reported traceback Testing performed: the user's testcase, ``` >>> from adafruit_itertools.adafruit_itertools import count >>> from adafruit_itertools.adafruit_itertools_extras import take >>> take(1, count(1, 5)) [1] ``` Closes: #3
For technical reasons, pylint can't treat adafruit_itertools as a package when analyzing it, leading to the reported diagnostic ************* Module adafruit_itertools_extras E: 79, 0: Attempted relative import beyond top-level package (relative-beyond-top-level) Since creating an empty __init__.py would consume 512 valuable bytes of storage on a circuitpython device, instead just silence the message.
|
|
|
@dhalbert you'll have to teach me sometime |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 20, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#18 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to v1.0.1 from v1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#2 from brentru/fix-md5-import Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 1.0.1 from v1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#4 from jepler/issue3 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_binascii, Adafruit_CircuitPython_hashlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import statement incorrectly referred to the package, not the submodule, leading to the reported traceback
Testing performed: the user's testcase,
Closes: #3