#24 Fix enabling GPS for non-gps modules #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tekktrik, please let me know if I need to change anything here. It's my first open-source PR 😅 |
Signed-off-by: Ric Sapasap <[email protected]>
Signed-off-by: Ric Sapasap <[email protected]>
ric-sapasap
force-pushed
the
bugfix/issue-24
branch
from
54bf7f0 to
da576d5
Compare
|
Thanks for the submission! I'll take a look this evening! |
tekktrik
approved these changes
Jan 16, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 16, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 2.1.15 from 2.1.14: > Merge pull request adafruit/Adafruit_CircuitPython_FONA#25 from ric-sapasap/bugfix/issue-24 > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.4.7 from 3.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#47 from tcfranks/main > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#46 from tekktrik/dev/update-pylint > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.3.11 from 1.3.10: > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#17 from tcfranks/main > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.6 from 1.14.5: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#88 from Neradoc/documentation-add-text-index > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #24