Skip to content

#24 Fix enabling GPS for non-gps modules #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

ric-sapasap
Copy link
Contributor

Fix for #24

@ric-sapasap
Copy link
Contributor Author

Hi @tekktrik, please let me know if I need to change anything here. It's my first open-source PR 😅

ric-sapasap and others added 2 commits January 15, 2023 12:39
Signed-off-by: Ric Sapasap <[email protected]>
@tekktrik tekktrik self-requested a review January 15, 2023 21:55
@tekktrik
Copy link
Member

Thanks for the submission! I'll take a look this evening!

@tekktrik tekktrik linked an issue Jan 15, 2023 that may be closed by this pull request
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, thanks for the fix!

@tekktrik tekktrik merged commit 1531155 into adafruit:main Jan 16, 2023
@ric-sapasap ric-sapasap deleted the bugfix/issue-24 branch January 16, 2023 03:58
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 16, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 2.1.15 from 2.1.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_FONA#25 from ric-sapasap/bugfix/issue-24
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.4.7 from 3.4.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#47 from tcfranks/main
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#46 from tekktrik/dev/update-pylint
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.3.11 from 1.3.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#17 from tcfranks/main
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.6 from 1.14.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#88 from Neradoc/documentation-add-text-index
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when using adafruit_fona_network.CELLULAR
2 participants