Suggesting an error message solution #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also, the frequency setter already checks against trying to prescale a value < 3, but does not check the prescale result of > 255. |
tekktrik
requested changes
Jan 6, 2023
|
@tekktrik in florida for 10 days with only a phone. Will tend to this when I get home! |
|
submitted for review of suggested mod |
tekktrik
approved these changes
Jan 15, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 16, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 2.1.15 from 2.1.14: > Merge pull request adafruit/Adafruit_CircuitPython_FONA#25 from ric-sapasap/bugfix/issue-24 > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.4.7 from 3.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#47 from tcfranks/main > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#46 from tekktrik/dev/update-pylint > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.3.11 from 1.3.10: > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#17 from tcfranks/main > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.6 from 1.14.5: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#88 from Neradoc/documentation-add-text-index > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #29
submitted for review / comment.
My 2 cents. it appears the only way the prescale_reg value can go south (it's read when invoked, I think) would be for I2C to fail. According the the specsheet for PCA9685 chip, the register should be in the range of 0x03 <= value <= 0xFF. I've only suggested for the low end, but to be airtight do we want to go the full way? (spec sheet p 25 of 52)