Skip to content

Adding fields #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 16, 2021
Merged

Adding fields #15

merged 17 commits into from
Feb 16, 2021

Conversation

gpongelli
Copy link
Contributor

Explicitly adding all the MASK_ENABLE bits, MANUFACTURER and REVISION reg.

@ladyada ladyada requested a review from siddacious December 21, 2020 17:13
siddacious
siddacious reviewed Dec 21, 2020
View reviewed changes
siddacious
siddacious suggested changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@siddacious siddacious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing because there is not documentation for the new code. This will need to be fixed to merge.

Secondly, if you are going to add new features, please add one or more examples that show how to use the new features.

@siddacious
Copy link
Contributor

Thank you for your contribution! This particular library is near and dear to me, so it's great to see someone else chipping in!

@gpongelli
Copy link
Contributor Author

Thank you for this library!

I'm working on this chip with a custom board (not the Adafruit one) and this library is helping me a lot, instead of writing similar code to yours 😃

@siddacious
Copy link
Contributor

It looks like you're to the Black formatting check, almost there!
See here for more info:
https://learn.adafruit.com/improve-your-code-with-pylint/black

@gpongelli
Copy link
Contributor Author

@siddacious sorry but I do not understand what's still missing, could you help me ?

@siddacious
Copy link
Contributor

@gpongelli Please try to reproduce the sphinx build on your machine to see if you get the same errors.

You can use his guide for reference:
https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/testing-with-github-actions

@gpongelli
Copy link
Contributor Author

@siddacious was the pipeline executed before my branch did start ?
because I'm doing fixes over fixes on file part I've not touched, like the following rows from master commit

**Hardware:**

* `INA260 Breakout <https://www.adafruit.com/products/4226>`_

**Software and Dependencies:**

* Adafruit CircuitPython firmware for the supported boards:
  https://github.com/adafruit/circuitpython/releases

 * Adafruit's Bus Device library: https://github.com/adafruit/Adafruit_CircuitPython_BusDevice

 * Adafruit's Register library: https://github.com/adafruit/Adafruit_CircuitPython_Register

@siddacious
Copy link
Contributor

@gpongelli You're likely running into checks that were added after the last time a build was done on this repo.

Your help updating the code would be much appreciated

@gpongelli
Copy link
Contributor Author

gpongelli commented Dec 29, 2020 via email

@siddacious
Copy link
Contributor

@gpongelli please see my earlier request for change where I ask for an example that tests the new code. It will help me test as well as help users understand how to use the new features

@gpongelli
Copy link
Contributor Author

@siddacious look at the new example file and let me know

@gpongelli gpongelli requested a review from siddacious February 9, 2021 11:05
@gpongelli
Copy link
Contributor Author

@siddacious @ladyada anyone there?

@ladyada
Copy link
Member

ladyada commented Feb 15, 2021

hihi please adjust the PR so CI passes
https://github.com/adafruit/Adafruit_CircuitPython_INA260/runs/1862521113
we have a guide on linting
https://learn.adafruit.com/improve-your-code-with-pylint
@dherrada can help if you're not sure what to do

@gpongelli
Copy link
Contributor Author

gpongelli commented Feb 15, 2021 via email

@ladyada
Copy link
Member

ladyada commented Feb 15, 2021

yes we now require copyright deets!

@gpongelli
Adding fields
dc99e50 
Explicitly adding all the MASK_ENABLE bits, MANUFACTURER and REVISION registry
@gpongelli
Adding check on manufacturer and device id
b5f51ef
@gpongelli
adding system reset bit
45ca98c
@gpongelli
documentation
7e80763
@gpongelli
removing space only rows
f23ea1c
@gpongelli
fixing some lint check
e9df7b3 
I cannot fix errors on CRLF if any cause I'm working on windows.
@gpongelli
black executed
9e2db6f
@gpongelli
add missing import
8ae7e08
@gpongelli
adding static method to retrieve values
18f7da8 
giving register's content e.g.  ConversionTime.get_seconds(ConversionTime.TIME_332_us) will return 0.000332 .

similarly, ConversionTime.get_seconds(obj.voltage_conversion_time) will return the value reading from registry
@gpongelli
fix sphinx-build
de6d8b2
@gpongelli
fix for pylint
f5148c9
@gpongelli
remove trailing space
fb3ec4c
@gpongelli
Copy link
Contributor Author

@ladyada copyrights added after rebase, but still fails due to something runner-related issue.

@ladyada
Copy link
Member

ladyada commented Feb 16, 2021

weird - dunno what that error is.
@tannewt @dherrada plz take a look when yr around next

@evaherrada
Copy link
Collaborator

evaherrada commented Feb 16, 2021 •
edited
Loading

@ladyada @gpongelli Looks like an issue with the latest Pylint (pylint-dev/pylint#4097) 2.6.1. Should be fixed by just running the CI again when 2.6.2 gets released

Edit: looks like 2.6.2 has been released.

@evaherrada
Copy link
Collaborator

Yeah, looks like it was just a bug in 2.6.1. Seems to be fixed now.

@gpongelli
Copy link
Contributor Author

Pipeline now passes.

There’s still an old code review request already addressed.

@ladyada ladyada merged commit 13fd90e into adafruit:master Feb 16, 2021
@ladyada
Copy link
Member

ladyada commented Feb 16, 2021

aawesome

@gpongelli
Copy link
Contributor Author

thanks for merging this PR.

is it planned a 1.2.7 version sooner or later ?

@ladyada
Copy link
Member

ladyada commented Feb 17, 2021

there are version release sweeps once a week

@evaherrada
Copy link
Collaborator

@gpongelli Yep. This should be released tomorrow.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 24, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@f49a93b)
60f2c6a 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.6 from 3.5.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#62 from jposada202020/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.3.0 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#19 from SAK917/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#21 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.3.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA260#15 from gpongelli/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.0.4 from 1.0.3:
  > Changed py_modules to packages

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.0.3 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#10 from caternuson/remove_asc

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#10 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1681 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1681#3 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.4.4 from 1.4.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#22 from wildestpixel/patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.3.6 from 3.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#26 from caternuson/iss25

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#17 from OleMchls/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.0 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#15 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.7.0 from 1.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#56 from KTibow/patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.0.2 from 5.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#69 from dlizotte-uwo/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.7 from 3.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#52 from jedgarpark/pico-dc-motor-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.1.6 from 0.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#8 from jepler/commas

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#13 from Neradoc/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_SSD1681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@siddacious siddacious Awaiting requested review from siddacious

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gpongelli @siddacious @ladyada @evaherrada