Adjust gain values #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ladyada merged 1 commit into adafruit:master from OleMchls:patch-1

Feb 21, 2021

Contributor

OleMchls commented Feb 19, 2021 •

edited

Loading

I extensively studied the implementation while creating a VL6180X for Elixir nerves, and found these Gain values that definatly seem off. I also noticed some other oddities but want to just use review comments to ask for clarifications before adding code changes around it.

Everything in this PR is based on this datasheet: https://www.st.com/resource/en/datasheet/vl6180x.pdf


          Adjust gain values

6cedda5

OleMchls commented

View reviewed changes

Contributor Author

OleMchls left a comment

I can only commend on code close to my changes, so the rest goes in writing:

        self._write_8(_VL6180X_REG_SYSALS_INTEGRATION_PERIOD_HI, 0)
        self._write_8(_VL6180X_REG_SYSALS_INTEGRATION_PERIOD_LO, 100)

https://github.com/adafruit/Adafruit_CircuitPython_VL6180X/pull/17/files#diff-9f707f011a85c59e078609f72513b1ca856a8bda539725fad5e803149fe65125R130
This register is undocumented.

https://github.com/adafruit/Adafruit_CircuitPython_VL6180X/pull/17/files#diff-9f707f011a85c59e078609f72513b1ca856a8bda539725fad5e803149fe65125R129
The datasheet here recommends a value off 100, it seems the registers here were kind of mixed up.

adafruit_vl6180x.py

Comment on lines 163 to 164

		lux *= 100
		lux /= 100 # integration time in ms

Contributor Author

OleMchls Feb 19, 2021

This seems strange to me. Is that just to enfore float to be returned? Wouldnt then just

Suggested change

      
                    lux *= 100
          
                    lux /= 100  # integration time in ms
          
                    lux /= 1

suffice?

ladyada approved these changes

View reviewed changes

ladyada merged commit e26b4ac into adafruit:master

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@f49a93b)

60f2c6a

Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.6 from 3.5.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#62 from jposada202020/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.3.0 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#19 from SAK917/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#21 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.3.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA260#15 from gpongelli/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.0.4 from 1.0.3:
  > Changed py_modules to packages

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.0.3 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#10 from caternuson/remove_asc

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#10 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1681 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1681#3 from makermelissa/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.4.4 from 1.4.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#22 from wildestpixel/patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.3.6 from 3.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#26 from caternuson/iss25

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#17 from OleMchls/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.0 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#15 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.7.0 from 1.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#56 from KTibow/patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.0.2 from 5.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#69 from dlizotte-uwo/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.7 from 3.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#52 from jedgarpark/pico-dc-motor-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.1.6 from 0.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#8 from jepler/commas

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#13 from Neradoc/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_SSD1681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet