Skip to content

Re-add slashed into signatures #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Re-add slashed into signatures #38

merged 1 commit into from
Feb 13, 2024

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented Feb 13, 2024

Since #36 is resolved, replacing the , / in io.py I removed as well as 2 other instances I saw.

@justmobilize justmobilize marked this pull request as ready for review February 13, 2024 19:14
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@dhalbert dhalbert merged commit 8f48054 into adafruit:main Feb 13, 2024
@justmobilize justmobilize deleted the re-add-slash-signatures branch February 13, 2024 19:25
@theyosh
Copy link

theyosh commented Feb 13, 2024

This breaks 3.7.3 support :( What is the lowest Python 3 version that should be supported?

@dhalbert
Copy link
Contributor

@theyosh Are you using 3.7.3? If so on what platform? 3.7 was end-of-life as of June 2023.

@theyosh
Copy link

theyosh commented Feb 13, 2024

Yeah, I know. But I am still supporting Raspbian OS buster with my software. I know it is old. But I use the hardware encoding of the GPU.

I am working to go to Bookworm. And I can pin the version for this library. So it is not that big of an issue. But I did not see any minimum python requirement.

@dhalbert
Copy link
Contributor

This library did have the , /) in it before, and we took it out just a few days ago, in #35, temporarily, and are now restoring that. So were you having trouble before?

@theyosh
Copy link

theyosh commented Feb 13, 2024

Then I/we just misted it. I am just working on this today... And it released a new version 2 weeks ago. So that just missed each other.

And I do not test my installation that much. And other people using my code also not reinstall much. So I think I am lucky with this one, and will update my requirements to get the working version.

So no worries, I will fix it on my side and will upgrade to Python 3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants