docs: update examples to use newer React syntax #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use `createRoot` for `react-dom` rendering - use functional components with hooks syntax - add link to `ref` docs - consistently use `sigCanvas` as name - don't switch b/t `sigPad` and `sigCanvas` - consistently format `example/` dir with `ts-standard` - was previously ignored for less diff, but since the example is re-written with newer syntax, good timing to reformat it too
This comment was marked as resolved.
This comment was marked as resolved.
Completed now. Had to do a solid amount of rebasing and editing to update this to latest, but it works now and is, as it was before, only a few commits on top of
Also completed now, but differently than written. As CRA is now deprecated (facebook/create-react-app#17003), I made the CodeSandbox use See the new |
Docs were updated to this new link in #120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update examples to latest React syntax;
createRoot+ hooksDetails
createRootforreact-domrenderingMisc docs/example improvements
add link to
refdocsconsistently use
sigCanvasas namesigPadandsigCanvasconsistently format
example/dir withts-standardVerification
npm startexample runs, renders, clears, and trimsFuture Work
Update thegh-pagesbranch as wellUpdate thecra-examplebranch used for the CodeSandbox as wellEDIT: Completed both, see below comment