Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link to new CodeSandbox example #120

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

agilgur5
Copy link
Owner

Summary

Per #119 (comment), the CodeSandbox was migrated off of CRA as it is now deprecated (facebook/create-react-app#17003)

Details

  • the CodeSandbox example now uses Parcel same as the example/ dir and gh-pages branch

    • the branch is now codesandbox-example as the name cra-example would no longer match
      • left the cra-example branch as-is for now, so that any links to it / it's CodeSandbox continue working (still works, just uses older deps)
  • also modify some whitespace in this section for better readability of the raw markdown

- using `parcel` same as the `example/` dir and `gh-pages` branch
  - as CRA is now deprecated

- also modify some whitespace in this section for better readability of the raw markdown
@agilgur5 agilgur5 added scope: docs Documentation could be improved scope: example An example or examples could be improved labels Feb 14, 2025

This comment was marked as resolved.

Copy link
Owner Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@agilgur5 agilgur5 merged commit f3108fd into main Feb 14, 2025
8 checks passed
@agilgur5 agilgur5 deleted the docs-codesandbox-update branch February 14, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs Documentation could be improved scope: example An example or examples could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant